[rds-devel] [PATCH net 1/2] net/rds: Replace direct refcount_inc() by inline function

David Miller davem at davemloft.net
Tue Apr 7 13:19:11 PDT 2020


From: Leon Romanovsky <leon at kernel.org>
Date: Tue, 7 Apr 2020 21:48:09 +0300

> On Tue, Apr 07, 2020 at 09:08:01AM -0700, Ka-Cheong Poon wrote:
>> Added rds_ib_dev_get() and rds_mr_get() to improve code readability.
> 
> It is very hard to agree with this sentence.
> Hiding basic kernel primitives is very rare will improve code readability.
> It is definitely not the case here.

I completely agree.



More information about the rds-devel mailing list