[rds-devel] [bug report] net: rds: add service level support in rds-info

[Dan Carpenter]

Hello Zhu Yanjun,

This is a semi-automatic email about new static checker warnings.

The patch e0e6d0628225: "net: rds: add service level support in
rds-info" from Aug 23, 2019, leads to the following Smatch complaint:

    net/rds/ib.c:314 rds_ib_conn_info_visitor()
    error: we previously assumed 'ic' could be null (see line 304)

net/rds/ib.c
   303		iinfo->dst_addr = conn->c_faddr.s6_addr32[3];
   304		if (ic) {
                    ^^
New check for NULL.

   305			iinfo->tos = conn->c_tos;
   306			iinfo->sl = ic->i_sl;
   307		}
   308	
   309		memset(&iinfo->src_gid, 0, sizeof(iinfo->src_gid));
   310		memset(&iinfo->dst_gid, 0, sizeof(iinfo->dst_gid));
   311		if (rds_conn_state(conn) == RDS_CONN_UP) {
   312			struct rds_ib_device *rds_ibdev;
   313	
   314			rdma_read_gids(ic->i_cm_id, (union ib_gid *)&iinfo->src_gid,
                                       ^^^^^^^^^^^
Unchecked dereference for old existing code.

   315				       (union ib_gid *)&iinfo->dst_gid);
   316	

regards,
dan carpenter