[rds-devel] [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr
Sowmini Varadhan
sowmini.varadhan at oracle.com
Fri Jul 6 03:15:05 PDT 2018
On (07/06/18 17:08), Ka-Cheong Poon wrote:
> >Hmm. Why do you need to include tcp header in ib transport
> >code ? If there is any common function just move to core
> >common file and use it.
>
> I think it can be removed as it is left over from earlier
> changes when the IB IPv6 listener port was RDS_TCP_PORT.
> Now all the port definitions are in rds.h.
Transport specific information such as port numbers should not
be smeared into the common rds-module. Please fix that.
If IB is also piggybacking on port 16385 (why?), please use your
own definitions for it in IB specific header files.
Santosh, David, I have to NACK this if it is not changed.
--Sowmini
More information about the rds-devel
mailing list