[rds-devel] [PATCH V2 net-next 4/7] rds: support for zcopy completion notification

Sowmini Varadhan sowmini.varadhan at oracle.com
Thu Feb 15 04:03:31 PST 2018


On (02/14/18 19:41), Willem de Bruijn wrote:
> 
> One more thing: this code notifies that the operation succeeded, but
> the data was copied in the process. It does not have to be set otherwise.

I see. this one was a bit confusing for me (hence the copy/paste) -
maybe because the TCP/UDP/PACKET case is a bit different from RDS,
and sendmsg may find that it has to switch from zcopy to bcopy 
after the sendmsg() itself has returned, but this cannot happen
for RDS (thus I should never set this code?).

Is it ok if I fix this in the next round or do you think
this warrants a V3?

--Sowmini 



More information about the rds-devel mailing list