[rds-devel] [PATCH 1/1] Revert "rds: ib: add error handle"

[Dag Moxnes]

I was going to suggest the following correction:


If all agree that this is the correct way of doing it, I can go ahead 
and an post it.

Regards,

-Dag


On 04/24/2018 01:10 PM, Håkon Bugge wrote:
>
>> On 24 Apr 2018, at 05:27, santosh.shilimkar at oracle.com wrote:
>>
>> On 4/23/18 6:39 PM, Zhu Yanjun wrote:
>>> This reverts commit 3b12f73a5c2977153f28a224392fd4729b50d1dc.
>>> After long time discussion and investigations, it seems that there
>>> is no mem leak. So this patch is reverted.
>>> Signed-off-by: Zhu Yanjun <yanjun.zhu at oracle.com>
>>> ---
>> Well your fix was not for any leaks but just proper labels for
>> graceful exits. I don't know which long time discussion
>> you are referring but there is no need to revert this change
>> unless you see any issue with your change.
> As spotted by Dax Moxnes, the patch misses to call rds_ib_dev_put() when exiting normally, only on err exit.
>
>
> Thxs, Håkon
>
>> Regards,
>> Santosh
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-rds-ib-Fix-missing-call-to-rds_ib_dev_put-in-rds_ib_.patch
Type: text/x-patch
Size: 1185 bytes
Desc: not available
Url : http://oss.oracle.com/pipermail/rds-devel/attachments/20180424/742487ae/attachment.bin