[rds-devel] [PATCHv2 3/5] rds: ib: remove redundant ib_dealloc_fmr
Santosh Shilimkar
santosh.shilimkar at oracle.com
Thu Mar 9 08:51:59 PST 2017
On 3/9/2017 1:20 AM, Zhu Yanjun wrote:
> The function ib_dealloc_fmr will never be called. As such, it should
> be removed.
>
> Cc: Joe Jin <joe.jin at oracle.com>
> Cc: Junxiao Bi <junxiao.bi at oracle.com>
> Signed-off-by: Zhu Yanjun <yanjun.zhu at oracle.com>
> ---
> Change from v1 to v2:
> remove ibmr NULL test.
>
While posting updates, please post entire series and also
give some time between two posts.
> net/rds/ib_fmr.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/net/rds/ib_fmr.c b/net/rds/ib_fmr.c
> index 4fe8f4f..249ae1c 100644
> --- a/net/rds/ib_fmr.c
> +++ b/net/rds/ib_fmr.c
> @@ -78,12 +78,9 @@ struct rds_ib_mr *rds_ib_alloc_fmr(struct rds_ib_device *rds_ibdev, int npages)
> return ibmr;
>
> out_no_cigar:
> - if (ibmr) {
> - if (fmr->fmr)
> - ib_dealloc_fmr(fmr->fmr);
> - kfree(ibmr);
> - }
> + kfree(ibmr);
> atomic_dec(&pool->item_count);
> +
No need of the extra line here.
> return ERR_PTR(err);
> }
>
>
More information about the rds-devel
mailing list