[rds-devel] [PATCH net] RDS-TCP: Recover correctly from pskb_pull()/pksb_trim() failure in rds_tcp_data_recv
David Miller
davem at davemloft.net
Tue Oct 27 19:47:04 PDT 2015
From: Sowmini Varadhan <sowmini.varadhan at oracle.com>
Date: Mon, 26 Oct 2015 12:46:37 -0400
> Either of pskb_pull() or pskb_trim() may fail under low memory conditions.
> If rds_tcp_data_recv() ignores such failures, the application will
> receive corrupted data because the skb has not been correctly
> carved to the RDS datagram size.
>
> Avoid this by handling pskb_pull/pskb_trim failure in the same
> manner as the skb_clone failure: bail out of rds_tcp_data_recv(), and
> retry via the deferred call to rds_send_worker() that gets set up on
> ENOMEM from rds_tcp_read_sock()
>
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan at oracle.com>
Applied and queued up for -stable, thanks.
More information about the rds-devel
mailing list