[rds-devel] [PATCH] net/rds: fix unaligned memory access

David Miller davem at davemloft.net
Thu Apr 30 08:44:03 PDT 2015


From: David Ahern <david.ahern at oracle.com>
Date: Thu, 30 Apr 2015 10:27:53 -0400

> @@ -183,8 +183,17 @@ void rds_ib_cm_connect_complete(struct rds_connection *conn, struct rdma_cm_even
>  
>  	/* If the peer gave us the last packet it saw, process this as if
>  	 * we had received a regular ACK. */
> -	if (dp && dp->dp_ack_seq)
> -		rds_send_drop_acked(conn, be64_to_cpu(dp->dp_ack_seq), NULL);
> +	if (dp) {
> +		/* dp structure start is not guaranteed to be 8 bytes aligned
> +		 * so on SPARC we get trap for nu-aligned access. we solve
> +		 * this by using the macros for unaligned memory access
> +		 */

"nu-aligned" is misspelled, and Mentioning sparc specifically is completely
inappropriate because this is not a sparc specific problem.



More information about the rds-devel mailing list