[rds-devel] [PATCH 7/8] rds: Pass pointers to virt_to_page(), not integers

Venkat Venkatsubra venkat.x.venkatsubra at oracle.com
Mon Oct 28 07:22:55 PDT 2013


-----Original Message-----
From: David Miller [mailto:davem at davemloft.net] 
Sent: Sunday, October 27, 2013 11:27 PM
To: ben at decadent.org.uk
Cc: Venkat Venkatsubra; linux-kernel at vger.kernel.org; rds-devel at oss.oracle.com; netdev at vger.kernel.org
Subject: Re: [PATCH 7/8] rds: Pass pointers to virt_to_page(), not integers

From: Ben Hutchings <ben at decadent.org.uk>
Date: Sun, 27 Oct 2013 21:54:16 +0000

> Most architectures define virt_to_page() as a macro that casts its 
> argument such that an argument of type unsigned long will be accepted 
> without complaint.  However, the proper type is void *, and passing 
> unsigned long results in a warning on MIPS.
> 
> Compile-tested only.
> 
> Signed-off-by: Ben Hutchings <ben at decadent.org.uk>

This looks fine:

Acked-by: David S. Miller <davem at davemloft.net>
Acked-by: Venkat Venkatsubra <venkat.x.venkatsubra at oracle.com>



More information about the rds-devel mailing list