[rds-devel] [PATCH] rds: prevent BUG_ON triggered on congestion update to loopback

David Miller davem at davemloft.net
Sun Dec 1 17:19:30 PST 2013


From: Venkat Venkatsubra <venkat.x.venkatsubra at oracle.com>
Date: Mon, 25 Nov 2013 09:47:34 +0300

> From: Venkat Venkatsubra <venkat.x.venkatsubra at oracle.com>
> 
> After congestion update on a local connection, when rds_ib_xmit returns
> less bytes than that are there in the message, rds_send_xmit calls
> back rds_ib_xmit with an offset that causes BUG_ON(off & RDS_FRAG_SIZE)
> to trigger.
> 
> Reported-by: Josh Hunt <joshhunt00 at gmail.com>
> Tested-by: Honggang Li <honli at redhat.com>
> Acked-by: Bang Nguyen <bang.nguyen at oracle.com>
> Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra at oracle.com>
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

Thanks Venkat, this is almost perfect.

Please adjust the commit message so that it contains all of the analysis
you posted before.  You can never include too much information, especially
for a fix for a bug that languished for such a long time like this one
did.  In particular you should mentioned the ppc bug fix that introduced
this regression, reference such commits in the following format:

	$SHA1_ID ("Commit message header text")

Thanks.



More information about the rds-devel mailing list