[rds-devel] [PATCH v2] RDS: fix rds-ping spinlock recursion

[David Miller]

From: Jeff Liu <jeff.liu at oracle.com>
Date: Tue, 09 Oct 2012 12:57:27 +0800

> This is the revised patch for fixing rds-ping spinlock recursion according to Venkat's suggestions.
> 
> RDS ping/pong over TCP feature has been broken for years(2.6.39 to 3.6.0) since we
> have to set TCP cork and call kernel_sendmsg() between ping/pong which both need to
> lock "struct sock *sk". However, this lock has already been hold before rds_tcp_data_ready()
> callback is triggerred. As a result, we always facing spinlock resursion which would resulting
> in system panic.
> 
> Given that RDS ping is only used to test the connectivity and not for serious performance measurements,
> we can queue the pong transmit to rds_wq as a delayed response.
> 
> Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> CC: Venkat Venkatsubra <venkat.x.venkatsubra at oracle.com>
> CC: David S. Miller <davem at davemloft.net>
> CC: James Morris <james.l.morris at oracle.com>
> Signed-off-by: Jie Liu <jeff.liu at oracle.com>

Applied and queued up for -stable, thanks.