[rds-devel] Please pull for OFED 1.5

[Vladimir Sokolovsky]

Andy Grover wrote:
> Hi Vlad, please pull the following RDS changes for OFED 1.5.
> 
> Also, I've updated git://git.openfabrics.org/~agrover/rds-tools.git, but
> I don't see an ofed_1_5/rds-tools.git created since the last rds-tools
> set of changes? Should I expect this or is there a different procedure?
> 
> Thanks -- Regards -- Andy
> 
> The following changes since commit 53f7b51485bcd6ba8c06f31c6fb2cc17adc2498a:
>   Yevgeny Petrilin (1):
>         mlx4_core: Rename MSI-X vectors
> 
> are available in the git repository at:
> 
>   git://git.openfabrics.org/~agrover/ofed_1_5/linux-2.6.git
> code-drop/20091027
> 
> Andy Grover (4):
>       RDS: Fix potential race around rds_i[bw]_allocation
>       RDS: Fix panic on unload
>       RDS: Do not send congestion updates to loopback connections
>       RDS/IB+IW: Move recv processing to a tasklet
> 
>  net/rds/cong.c    |    2 ++
>  net/rds/ib.h      |    2 ++
>  net/rds/ib_cm.c   |    2 ++
>  net/rds/ib_rdma.c |    5 +----
>  net/rds/ib_recv.c |   35 ++++++++++++++++++++++++++---------
>  net/rds/iw.h      |    2 ++
>  net/rds/iw_cm.c   |    2 ++
>  net/rds/iw_rdma.c |    5 +----
>  net/rds/iw_recv.c |   35 ++++++++++++++++++++++++++---------
>  9 files changed, 64 insertions(+), 26 deletions(-)
> 


Hi Andy,

rds-tools source RPM is taken into OFED-1.5 from: 
http://www.openfabrics.org/~vlad/ofed_1_5/rds-tools
I pulled your rds-tools updates and built source RPM using "make rpm".

code-drop/20091027 requires backports for RHEL4.6/7/8:
Note: loading RDS modules cause kernel oops on RH4.6/7/8 (before 
code-drop/20091027).

Here is compilation log:
Build failed on x86_64 with linux-2.6.9-67.ELsmp
Log:
include/linux/skbuff.h: In function 'skb_add_data':
include/linux/skbuff.h:1041: warning: pointer targets in passing 
argument 2 of 'csum_partial_copy_from_user' differ in signedness
/home/vlad/tmp/ofa_1_5_kernel-20091028-0324_linux-2.6.9-67.ELsmp_x86_64_check/net/rds/ib_recv.c: 
In function 'rds_ib_recv_refill_one':
/home/vlad/tmp/ofa_1_5_kernel-20091028-0324_linux-2.6.9-67.ELsmp_x86_64_check/net/rds/ib_recv.c:146: 
error: implicit declaration of function 'atomic_add_unless'
make[3]: *** 
[/home/vlad/tmp/ofa_1_5_kernel-20091028-0324_linux-2.6.9-67.ELsmp_x86_64_check/net/rds/ib_recv.o] 
Error 1
make[2]: *** 
[/home/vlad/tmp/ofa_1_5_kernel-20091028-0324_linux-2.6.9-67.ELsmp_x86_64_check/net/rds] 
Error 2
make[1]: *** 
[_module_/home/vlad/tmp/ofa_1_5_kernel-20091028-0324_linux-2.6.9-67.ELsmp_x86_64_check] 
Error 2
make[1]: Leaving directory 
`/home/vlad/kernel.org/x86_64/linux-2.6.9-67.ELsmp'
make: *** [kernel] Error 2
----------------------------------------------------------------------------------
Build failed on x86_64 with linux-2.6.9-78.ELsmp
Log:
include/linux/skbuff.h: In function 'skb_add_data':
include/linux/skbuff.h:1041: warning: pointer targets in passing 
argument 2 of 'csum_partial_copy_from_user' differ in signedness
/home/vlad/tmp/ofa_1_5_kernel-20091028-0324_linux-2.6.9-78.ELsmp_x86_64_check/net/rds/ib_recv.c: 
In function 'rds_ib_recv_refill_one':
/home/vlad/tmp/ofa_1_5_kernel-20091028-0324_linux-2.6.9-78.ELsmp_x86_64_check/net/rds/ib_recv.c:146: 
error: implicit declaration of function 'atomic_add_unless'
make[3]: *** 
[/home/vlad/tmp/ofa_1_5_kernel-20091028-0324_linux-2.6.9-78.ELsmp_x86_64_check/net/rds/ib_recv.o] 
Error 1
make[2]: *** 
[/home/vlad/tmp/ofa_1_5_kernel-20091028-0324_linux-2.6.9-78.ELsmp_x86_64_check/net/rds] 
Error 2
make[1]: *** 
[_module_/home/vlad/tmp/ofa_1_5_kernel-20091028-0324_linux-2.6.9-78.ELsmp_x86_64_check] 
Error 2
make[1]: Leaving directory 
`/home/vlad/kernel.org/x86_64/linux-2.6.9-78.ELsmp'
make: *** [kernel] Error 2
----------------------------------------------------------------------------------

Regards,
Vladimir