[rds-devel] [PATCH 11/12] ERR_PTR() dereference in net/rds/ib.c
Andy Grover
andy.grover at oracle.com
Thu Apr 9 17:09:46 PDT 2009
From: Dan Carpenter <error27 at gmail.com>
rdma_create_id() doesn't return NULL, only ERR_PTR().
Found by smatch (http://repo.or.cz/w/smatch.git). Compile tested.
regards,
dan carpenter
Signed-off-by: Dan Carpenter <error27 at gmail.com>
Signed-off-by: Andy Grover <andy.grover at oracle.com>
---
net/rds/ib.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/rds/ib.c b/net/rds/ib.c
index 4933b38..b9bcd32 100644
--- a/net/rds/ib.c
+++ b/net/rds/ib.c
@@ -224,8 +224,8 @@ static int rds_ib_laddr_check(__be32 addr)
* IB and iWARP capable NICs.
*/
cm_id = rdma_create_id(NULL, NULL, RDMA_PS_TCP);
- if (!cm_id)
- return -EADDRNOTAVAIL;
+ if (IS_ERR(cm_id))
+ return PTR_ERR(cm_id);
memset(&sin, 0, sizeof(sin));
sin.sin_family = AF_INET;
--
1.5.6.3
More information about the rds-devel
mailing list