[rds-devel] rds_conn_shutdown() issue.

[Olaf Kirch]

On Wednesday 07 May 2008 19:01:02 Pradeep wrote:
> 
> Hello,
> 
> In rds_conn_shutdown(), shouldn't there be a check before freeing 
> send/recv rings
> (i_sends/i_recvs)? These could be NULL in case of a route lookup failure
> (RDMA_CM_EVENT_ROUTE_ERROR) - QP isn't setup yet.

I think it's safe to call kfree on a NULL pointer. At least that's what
the code currently does - but I'm not sure whether it's good style to
rely on that or not.

Olaf
-- 
Olaf Kirch  |  --- o --- Nous sommes du soleil we love when we play
okir at lst.de |    / | \   sol.dhoop.naytheet.ah kin.ir.samse.qurax