[rds-devel] Re: [PATCH] Implement our own RDMA MR pool

[Or Gerlitz]

Roland Dreier wrote:
> This made me read over the mthca implementation of FMRs carefully, and
> I think I see a bug.  Can you try the patch below and see if it makes
> a difference?
> 
> diff --git a/drivers/infiniband/hw/mthca/mthca_mr.c 
> b/drivers/infiniband/hw/mthca/mthca_mr.c
> index 3b69855..3538da1 100644
> --- a/drivers/infiniband/hw/mthca/mthca_mr.c
> +++ b/drivers/infiniband/hw/mthca/mthca_mr.c
> @@ -686,7 +686,7 @@ err_out_table:
>         mthca_table_put(dev, dev->mr_table.mpt_table, key);
> 
>  err_out_mpt_free:
> -       mthca_free(&dev->mr_table.mpt_alloc, mr->ibmr.lkey);
> +       mthca_free(&dev->mr_table.mpt_alloc, key);
>         return err;
>  }

I think that at this point Olaf stopped getting into the error path of 
fmr allocation and hence maybe was not able to comment... anyway, do we 
want this patch in? it seems that it somehow found its way into the ofed 
1.3 tree even though I fail to find the commit, Jack can you comment?

Or