[rds-devel] Re: [PATCH 2/2] RDS: Fix a crash on rmmod
Olaf Kirch
olaf.kirch at oracle.com
Wed Nov 14 10:14:26 PST 2007
From: Olaf Kirch <olaf.kirch at oracle.com>
RDS: Fix a crash on rmmod
This fixes a crash in rds_ib_remove_one - we really should
be using list_for_each_entry_safe here.
Signed-off-by: Olaf Kirch <olaf.kirch at oracle.com>
---
net/rds/ib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: ofa-kernel-1.3plus/net/rds/ib.c
===================================================================
--- ofa-kernel-1.3plus.orig/net/rds/ib.c
+++ ofa-kernel-1.3plus/net/rds/ib.c
@@ -133,11 +133,11 @@ free_attr:
void rds_ib_remove_one(struct ib_device *device)
{
struct rds_ib_device *rds_ibdev;
- struct rds_ib_ipaddr *i_ipaddr;
+ struct rds_ib_ipaddr *i_ipaddr, *next;
rds_ibdev = ib_get_client_data(device, &rds_ib_client);
- list_for_each_entry(i_ipaddr, &rds_ibdev->ipaddr_list, list) {
+ list_for_each_entry_safe(i_ipaddr, next, &rds_ibdev->ipaddr_list, list) {
list_del(&i_ipaddr->list);
kfree(i_ipaddr);
}
--
Olaf Kirch | --- o --- Nous sommes du soleil we love when we play
okir at lst.de | / | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax
More information about the rds-devel
mailing list