[rds-devel] Re: [PATCH 2/2] RDS: clear RDS_CONN_CONNECTING bit when connecting process finished and connection established

Zach Brown zach.brown at oracle.com
Mon Jun 11 08:46:40 PDT 2007


On Jun 10, 2007, at 11:09 AM, Vladimir Sokolovsky wrote:

> Hi Zach,
> I think that it is logically correct to clear RDS_CONN_CONNECTING bit
> when connection established and RDS_CONN_CONNECTED bit is set.

So?  If the patch doesn't fix some problem I don't see why we should  
risk the damage it might cause.  You don't mention the effect this  
patch has on paths that just test CONNECTING now that it isn't set  
for the lifetime of the established connection.

- z



More information about the rds-devel mailing list