[rds-devel] Re: [PATCH 1/2] RDS/IB: Handle connection request in case of failover.

[Zach Brown]

> Hi Zach,
> Please review the following two patches:

Sure.  Your patches don't have complete descriptions, though, so I'm
forced to ask questions.

>         /*
> +        * the connection request may occur while the
> +        * previous connection exist. E.g. in case of failover
> +        */

This logic seems to duplicate the logic under the test for _CONNECTING,
with the addition of setting i_wc_err.  Why do these connection attempts
get to the BUG_ON() instead of noticing that _CONNECTING is set on the
existing connection?  That should trigger a shutdown, just like these
tests you added do.

- z