[rds-devel] [PATCH] RDS/IB: Fix memory leak on the HCA driver unload.

Or Gerlitz ogerlitz at voltaire.com
Thu Dec 20 03:44:15 PST 2007


Vladimir Sokolovsky wrote:
> Or Gerlitz wrote:

>> My thinking is that the correct way to follow here, is to remove from 
>> rds the code that uses the client register API and rely on the rdma-cm 
>> only.

> What about all per device structures: mr, fmr, pd (rds_ib_add_one)?

They all will remain in struct rds_ib_device, its just the creation of 
an instance of this structure would be carried out "on demand" that is 
when RDS gets to use an IB device for the first time (eg on the first 
address resolution that turned to be going out from this device or on 
the first connection request that arrived through this device). Later, 
next usages of that IB device will just ref / unref the device. When the 
reference count gets to zero, we can free the resources, etc.

Or.





More information about the rds-devel mailing list