<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffcc" text="#000066">
<tt>Tao,<br>
<br>
After looking at the tests.<br>
<br>
<br>
<br>
1. test_remove.c. I think you should rename it before checking it in.
The name is generic and I think it should be remove_slot.c. You can
group tests better if the script/program have the same name or
something that would relate them.<br>
<br>
2. corrupt.patch. I don't see any problem using it, but it would be
something that one will always have to remember to apply before running
this specific test. I don't know if we could use a hidden parameter in
tunefs.ocfs2 and make it permanent. Also, I think the name should be a
little more descriptive and point to what program (tunefs.ocfs2) it is
affecting.<br>
<br>
3. The patch has the script named as test_remove_slot.patch in the
Makefile. Needs to fix that.<br>
<br>
Also, have to include "SUBDIRS = remove-slot" in the
programs/tunefs-test/Makefile so that it can build and install.<br>
<br>
<br>
I'm running tests right now.<br>
</tt><br>
tao.ma wrote:
<blockquote cite="mid:4694A0EF.5070500@oracle.com" type="cite">Add test
script in ocfs2-test to test whether removing can work OK.
<br>
<br>
1. test_remove.c
<br>
This file is used to create some boudary situation to test whether
<br>
tunefs.ocfs2 can work OK with removing slots.
<br>
When we have orphan files or have some blocks allocated in truncate log
<br>
or local alloc, we can't remove the slots, so the option
CREATE_ORPHAN_FILE,
<br>
CREATE_TRUNCATE_LOG and CREATE_LOCAL_ALLOC are used to check it.
<br>
<br>
2. corrupt.patch
<br>
With this patch, tunefs.ocfs2 will abort at the specified place and we
can check
<br>
whether fsck.ocfs2 can fix the aborted problem.
<br>
<br>
3. remove_slot.patch
<br>
The main test script to test removing slots.
<br>
<br>
<br>
<pre wrap=""><pre wrap="">
<hr size="4" width="90%">
_______________________________________________
Ocfs2-tools-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Ocfs2-tools-devel@oss.oracle.com">Ocfs2-tools-devel@oss.oracle.com</a>
<a class="moz-txt-link-freetext" href="http://oss.oracle.com/mailman/listinfo/ocfs2-tools-devel">http://oss.oracle.com/mailman/listinfo/ocfs2-tools-devel</a></pre></pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Regards,
Marcos Eduardo Matsunaga
Oracle USA
Linux Engineering
</pre>
</body>
</html>