<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Jun,<br>
</p>
<div class="moz-cite-prefix">On 11/19/18 8:54 AM, piaojun wrote:<br>
</div>
<blockquote type="cite" cite="mid:5BF209D6.6040900@huawei.com">
<blockquote type="cite" style="color: #000000;">
<pre class="moz-quote-pre" wrap="">diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c
index 7642b6712c39..755ec2aa2db0 100644
--- a/fs/ocfs2/localalloc.c
+++ b/fs/ocfs2/localalloc.c
@@ -345,13 +345,18 @@ int ocfs2_load_local_alloc(struct ocfs2_super *osb)
if (num_used
|| alloc->id1.bitmap1.i_used
|| alloc->id1.bitmap1.i_total
- || la->la_bm_off)
- mlog(ML_ERROR, "Local alloc hasn't been recovered!\n"
+ || la->la_bm_off) {
+ mlog(ML_ERROR, "inconsistent detected, clean journal with"
+ "unrecovered local alloc, please run fsck.ocfs2!\n"
"found = %u, set = %u, taken = %u, off = %u\n",
num_used, le32_to_cpu(alloc->id1.bitmap1.i_used),
le32_to_cpu(alloc->id1.bitmap1.i_total),
OCFS2_LOCAL_ALLOC(alloc)->la_bm_off);
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">Could we try to recover local alloc with
ocfs2_begin_local_alloc_recovery() automatically if it's dirty? And fsck
seems a little heavy.</pre>
</blockquote>
<p>I supposed the "dirty" here you mean local alloc.</p>
<p>As i have mentioned in the patch log, recover it during mount is
not safe. There could be io error happened after mark journal
clean, so corruption may happen to local alloc and other
metadata, run a full fsck is to avoid further corruption.<br>
</p>
<p>Thanks,</p>
<p>Junxiao.<br>
</p>
<blockquote type="cite" cite="mid:5BF209D6.6040900@huawei.com">
<pre class="moz-quote-pre" wrap="">
Thanks,
Jun
</pre>
</blockquote>
</body>
</html>