<html><head><meta http-equiv=Content-Type content="text/html; charset=UTF-8"><META name="Author" content="GroupWise WebAccess"><style type="text/css">
body p
{
margin: 0px;
}
</style></head><body style='font-family: Helvetica, Arial, sans-serif; font-size: 13px; '><div id="GroupWiseSection_1519887120000_lchen@suse.com_053DBC8018D600009F61706166646230_" class="GroupWiseMessageBody"><div>Hi Changwei,</div><br><div>Thanks for your review.</div><br><div>I think the original comment is not as clear as you said since </div><div>the code does not reflect any relation between lockid and blockid.</div><br><div>Besides, the function inside indeed uses the block number for</div><div>comparision. And it's really misleading for new beginners ,emmmm, like me. </div><br><div>:)</div><br><div>Thanks,</div><div>Larry</div><br><br><span> </span><span class="GroupwiseReplyHeader"><br><br>>>> Changwei Ge <ge.changwei@h3c.com> 2018-3-1 上午 8:37 >>><br></span>Hi Larry,<br><br>On 2018/2/28 18:18, Larry Chen wrote:<br>> The function ocfs2_double_lock tries to lock the inode with lower<br>> blockid first, not lockid.<br><br>As ocfs2's lock name includes block number, so I think the comment you want to <br>rework is all right.<br>So nack.<br><br>Thanks,<br>Changwei<br><br>> <br>> Signed-off-by: Larry Chen <lchen@suse.com><br>> ---<br>> fs/ocfs2/namei.c | 2 +-<br>> 1 file changed, 1 insertion(+), 1 deletion(-)<br>> <br>> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c<br>> index c801eddc4bf3..30d454de35a8 100644<br>> --- a/fs/ocfs2/namei.c<br>> +++ b/fs/ocfs2/namei.c<br>> @@ -1133,7 +1133,7 @@ static int ocfs2_double_lock(struct ocfs2_super *osb,<br>> if (*bh2)<br>> *bh2 = NULL;<br>> <br>> - /* we always want to lock the one with the lower lockid first.<br>> + /* we always want to lock the one with the lower blockid first.<br>> * and if they are nested, we lock ancestor first */<br>> if (oi1->ip_blkno != oi2->ip_blkno) {<br>> inode1_is_ancestor = ocfs2_check_if_ancestor(osb, oi2->ip_blkno,<br>> <br><br><br></div></body></html>