<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
text-align:justify;
text-justify:inter-ideograph;
font-size:10.5pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.gt-baf-word-clickable
{mso-style-name:gt-baf-word-clickable;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
/* Page Definitions */
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-CN" link="#0563C1" vlink="#954F72" style="text-justify-trim:punctuation">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi all<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">In our test, We fond that , when the network down, qs->qs_holds may could not be reduce to zero, lead to the node can’t do fence.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">o2net_idle_timer -> o2quo_conn_err -> qs->qs_holds++, after O2NET_QUORUM_DELAY_MS if qs_holds could be subtract to zero, it could do make_decision.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">But if there are many nodes, when one node network down which contains o2net connections may not do o2net_idle_timer at the same time, so when a o2net_node have done nn->nn_still_up, but the qs_holds is not be zero, because
other o2net_node have not done nn->nn_still_up.so the first o2net_node will do o2net_idle_timer again, and the qs_holds could be add again. And the qs_holds is global variable, so it formed a loop, the node could not do o2quo_make_decision, because of qs_holds
never be zero.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I alter two functions o2quo_conn_up and o2quo_conn_err, take o2quo_set_hold or o2quo_clear_hold under control of the bit map qs_conn_bm<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:black">Best Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:black">Yang Zhang<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">@@ -280,20 +280,24 @@ void o2quo_conn_up(u8 node)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> struct o2quo_state *qs = &o2quo_state;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> spin_lock(&qs->qs_lock);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">-<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- qs->qs_connected++;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- mlog_bug_on_msg(qs->qs_connected == O2NM_MAX_NODES,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- "node %u\n", node);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- mlog_bug_on_msg(test_bit(node, qs->qs_conn_bm), "node %u\n", node);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- set_bit(node, qs->qs_conn_bm);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">-<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- mlog(0, "node %u, %d total\n", node, qs->qs_connected);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">-<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- if (!test_bit(node, qs->qs_hb_bm))<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- o2quo_set_hold(qs, node);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- else<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- o2quo_clear_hold(qs, node);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">-<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ if (!test_bit(node, qs->qs_conn_bm)) {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ qs->qs_connected++;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ mlog_bug_on_msg(qs->qs_connected == O2NM_MAX_NODES,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ "node %u\n", node);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ mlog_bug_on_msg(test_bit(node, qs->qs_conn_bm), "node %u\n", node);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ set_bit(node, qs->qs_conn_bm);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ mlog(0, "node %u, %d total\n", node, qs->qs_connected);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ if (!test_bit(node, qs->qs_hb_bm))<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ o2quo_set_hold(qs, node);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ else<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ o2quo_clear_hold(qs, node);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ }<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> spin_unlock(&qs->qs_lock);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">}<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">@@ -314,13 +318,13 @@ void o2quo_conn_err(u8 node)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> node, qs->qs_connected);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> clear_bit(node, qs->qs_conn_bm);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ if (test_bit(node, qs->qs_hb_bm))<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ o2quo_set_hold(qs, node);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> }<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> mlog(0, "node %u, %d total\n", node, qs->qs_connected);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- if (test_bit(node, qs->qs_hb_bm))<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- o2quo_set_hold(qs, node);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">-<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> spin_unlock(&qs->qs_lock);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">}<o:p></o:p></span></p>
</div>
</body>
</html>