<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style>body { line-height: 1.5; }blockquote { margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em; }p { margin-top: 0px; margin-bottom: 0px; }div.foxdiv20151218092400364529 { }body { font-size: 16pt; font-family: 微软雅黑; color: rgb(0, 0, 0); line-height: 1.5; }</style>
</head>
<body>
<div><font face="微软雅黑, Tahoma" size="2"><span style="line-height: normal;">Hi </span><a href="mailto:joseph.qi@huawei.com" class="" style="line-height: 18px;">Joseph</a></font></div>
<div><br>
</div>
<div><span style="font-family: 微软雅黑, Tahoma; font-size: small; line-height: normal;">The following locking order can cause a deadlock.</span><span style="font-family: 微软雅黑, Tahoma; font-size: small; line-height: normal; background-color: window;"> </span></div>
<div><font face="微软雅黑, Tahoma" size="2"> Node A Node B Node C</font></div>
<div><font face="微软雅黑, Tahoma" size="2"> Super lock <span style="line-height: 1.5;"> EX </span></font></div>
<div><span style="background-color: rgba(0, 0, 0, 0); font-family: '微软雅黑, Tahoma'; font-size: 13px; line-height: 1.5;"> </span><span style="font-size: small; line-height: 19px; background-color: window;">ocfs2_commit_thread</span><span style="background-color: window; font-family: 微软雅黑, Tahoma; font-size: small; line-height: 19px;"> </span></div>
<div><span style="font-family: '微软雅黑, Tahoma'; font-size: 13px; line-height: 1.5; background-color: window;"> </span><span style="font-size: small; line-height: 19px; background-color: window;">ocfs2_commit_cache</span><span style="background-color: window; font-family: 微软雅黑, Tahoma; font-size: small; line-height: 19px;"> </span></div>
<div><span style="font-family: '微软雅黑, Tahoma'; font-size: 13px; line-height: 1.5; background-color: window;"> </span><font size="2"><span style="background-color: rgb(255, 255, 255);"><span style="line-height: 1.5;"> </span><span style="line-height: 1.5;">
</span><span style="line-height: 1.5;"> </span><span style="line-height: 19px;">jbd2_journal_flush</span><span style="line-height: 19px;">
</span></span></font><font face="微软雅黑, Tahoma" size="2" style="background-color: window;"><span style="line-height: 1.5;">while journal</span></font><span style="font-size: small; line-height: 19px; background-color: window;"> is aborted , </span><font size="2" style="background-color: window;">have
been -EIO error. </font><span style="background-color: window; font-family: 微软雅黑, Tahoma; font-size: small; line-height: 19px;"> </span></div>
<div><span style="line-height: 1.5;"><font face="\微软雅黑, Tahoma\" size="2"> do not wake_up(&osb->dc_event) </font></span></div>
<div><span style="font-size: small; background-color: window;"> </span><span style="font-family: 微软雅黑, Tahoma; font-size: small; line-height: normal; background-color: window;"> do not </span><span style="font-family: 微软雅黑, Tahoma; font-size: small; line-height: normal; background-color: window;"> downconvert
EX->NL</span></div>
<div><span style="font-family: 微软雅黑, Tahoma; font-size: small; line-height: normal; background-color: window;"><br>
</span></div>
<div><span style="font-family: 微软雅黑, Tahoma; font-size: small; line-height: normal;">while Node B required EX lock or PR lock, </span><span style="font-size: small; line-height: 19px; background-color: window;">may cause nodes hung. </span></div>
<div><span style="font-size: small; line-height: 19px; background-color: window;">So reset Node A, Node B and Node C will be normal. </span></div>
<div><span style="font-size: small; line-height: 19px; background-color: window;">Thanks a lot</span></div>
<hr style="width: 210px; height: 1px;" color="#b5c4df" size="1" align="left">
<div><span>
<div style="MARGIN: 10px; FONT-FAMILY: verdana; FONT-SIZE: 10pt">
<div>zhangguanghui</div>
</div>
</span></div>
<blockquote style="margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em;">
<div> </div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<div style="PADDING-RIGHT: 8px; PADDING-LEFT: 8px; FONT-SIZE: 12px;FONT-FAMILY:tahoma;COLOR:#000000; BACKGROUND: #efefef; PADDING-BOTTOM: 8px; PADDING-TOP: 8px">
<div><b>From:</b> <a href="mailto:joseph.qi@huawei.com" class="">Joseph Qi</a></div>
<div><b>Date:</b> 2015-12-18 09:05</div>
<div><b>To:</b> <a href="mailto:zhang.guanghui@h3c.com">zhangguanghui 10102 (CCPL)</a></div>
<div><b>CC:</b> <a href="mailto:ocfs2-devel@oss.oracle.com">ocfs2-devel@oss.oracle.com</a></div>
<div><b>Subject:</b> Re: [Ocfs2-devel] ocfs2 cannot continue when JBD2 has aborted the journal,</div>
</div>
</div>
<div>
<div class="FoxDiv20151218092400364529"><!-- Converted from text/plain format -->
<p><font size="2">Hi Guanghui,<br>
Could you please describe the problem you encountered more specifically?<br>
I don't think this change is in a fair way.<br>
<br>
On 2015/12/17 13:33, Zhangguanghui wrote:<br>
> Hi all,<br>
><br>
> A tiny race about JBD2 has aborted to jbd2_journal_flush,<br>
><br>
> because of unstable storage link and I/O stress.<br>
><br>
> while JBD2 state is aborted, have been -EIO error,<br>
><br>
> may cause all cluster nodes hung. so I thinks<br>
><br>
> JBD2 has aborted the journal, ocfs2 cannot continue and trigger ocfs2_abort.<br>
><br>
> Thanks, Any ideas about this patch?<br>
><br>
><br>
> description:<br>
><br>
> ocfs2_commit_thread<br>
> ocfs2_commit_cache<br>
> jbd2_journal_flush<br>
><br>
><br>
> --- journal.c 2015-12-17 11:36:39.140542941 +0800<br>
> +++ journal.c.diff 2015-12-17 11:39:21.308542922 +0800<br>
> @@ -328,6 +328,9 @@<br>
> if (status < 0) {<br>
> up_write(&journal->j_trans_barrier);<br>
> mlog_errno(status);<br>
> + if (is_journal_aborted(journal)) {<br>
> + ocfs2_abort(osb->sb, "Detect aborted journal,while committing cache.");<br>
> + }<br>
> goto finally;<br>
> }<br>
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------!<br>
---<br>
> zhangguanghui<br>
> -------------------------------------------------------------------------------------------------------------------------------------<br>
> 本邮件及其附件含有杭州华三通信技术有限公司的保密信息，仅限于发送给上面地址中列出<br>
> 的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、<br>
> 或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本<br>
> 邮件！<br>
> This e-mail and its attachments contain confidential information from H3C, which is<br>
> intended only for the person or entity whose address is listed above. Any use of the<br>
> information contained herein in any way (including, but not limited to, total or partial<br>
> disclosure, reproduction, or dissemination) by persons other than the intended<br>
> recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender<br>
> by phone or email immediately and delete it!<br>
><br>
><br>
> _______________________________________________<br>
> Ocfs2-devel mailing list<br>
> Ocfs2-devel@oss.oracle.com<br>
> <a href="https://oss.oracle.com/mailman/listinfo/ocfs2-devel">https://oss.oracle.com/mailman/listinfo/ocfs2-devel</a><br>
><br>
<br>
<br>
</font></p>
</div>
</div>
</blockquote>
</body>
</html>