<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<tt>H</tt><tt>i Guanghui,</tt><tt><br>
</tt><tt><br>
</tt><tt>I think I encounter an problem just like you. But </tt><tt>it's
not </tt><tt>race case.</tt><tt><br>
</tt><tt><br>
</tt><tt>Every time </tt><tt>ocfs2_commit_thread</tt><tt> receive
an error</tt><tt> from </tt><tt>jbd2_journal_flush (which may
cause by disk io error), it will continue to try commit journal.
But in this case, journal should run into abort state, so retry
commit is useless. And even worse, the lock resource hold by this
node can not be release, so entire cluster hung.</tt><tt><br>
</tt><tt><br>
</tt><tt>I have write a patch about this, and my solution is just
like yours, will send it in another email.</tt><tt><br>
</tt><tt><br>
</tt><tt>Thanks,</tt><tt><br>
</tt><tt>R</tt><tt>yan</tt><tt><br>
</tt><tt><br>
</tt>
<div class="moz-cite-prefix"><tt>On 12/17/2015 01:33 PM,
Zhangguanghui wrote:</tt><tt><br>
</tt></div>
<blockquote cite="mid:2015121713343524045332@h3c.com" type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<tt>
</tt>
<style>
<!--
body
{line-height:1.5}
body
{font-size:16pt;
font-family:微软雅黑;
color:rgb(0,0,0);
line-height:1.5}
-->
</style>
<div><tt><span></span></tt>
<pre style="line-height:normal; widows:1">Hi all,</pre>
<pre style="line-height:normal; widows:1">A tiny race about <span style="line-height:1.5">JBD2 </span>has aborted to jbd2_journal_flush, </pre>
<pre style="line-height:normal; widows:1"><font>because of unstable storage </font>link and I/O stress.</pre>
<pre style="line-height:normal; widows:1">while <span style="line-height:1.5">JBD2 </span>state is aborted, have been -EIO error,</pre>
<pre style="line-height:normal; widows:1">may cause all cluster nodes hung. so I thinks </pre>
<pre style="line-height:normal; widows:1"><span style="line-height:1.5">JBD2 has aborted the journal, ocfs2 cannot continue and </span><span style="line-height:1.5">trig</span><span style="line-height:1.5">ger </span><span style="line-height:1.5">ocfs2_abort</span><span style="line-height:1.5">. </span></pre>
<pre style="line-height:normal; widows:1"><span style="line-height:1.5">Thanks, </span>Any ideas about this patch?</pre>
<pre style="line-height:normal; widows:1">
</pre>
</div>
<div>
<pre style="line-height:normal; widows:1"><pre>description:</pre></pre>
<pre style="line-height:normal; widows:1">ocfs2_commit_thread
ocfs2_commit_cache
jbd2_journal_flush</pre>
<pre style="line-height:normal; widows:1">
</pre>
</div>
<div><tt>--- journal.c 2015-12-17 11:36:39.140542941 +0800</tt><tt><br>
</tt><tt>
+++ journal.c.diff 2015-12-17 11:39:21.308542922 +0800</tt><tt><br>
</tt><tt>
@@ -328,6 +328,9 @@</tt><tt><br>
</tt><tt>
if (status < 0) {</tt><tt><br>
</tt><tt>
up_write(&journal->j_trans_barrier);</tt><tt><br>
</tt><tt>
mlog_errno(status);</tt><tt><br>
</tt><tt>
+ if (is_journal_aborted(journal)) {</tt><tt><br>
</tt><tt>
+ ocfs2_abort(osb->sb, "Detect aborted journal,while
committing cache.");</tt><tt><br>
</tt><tt>
+ }</tt><tt><br>
</tt><tt>
goto finally;</tt><tt><br>
</tt><tt>
}</tt></div>
<hr style="width:210px; height:1px" color="#b5c4df" size="1"
align="left">
<div><span>
<div style="margin: 10px; font-size: 10pt;">
<div>zhangguanghui</div>
</div>
</span></div>
<tt><span style="font-size: 7.5pt; color: gray;"><span
lang="EN-US">-------------------------------------------------------------------------------------------------------------------------------------<br>
</span>本邮件及其附件含有杭州华三通信技术有限公司的保密信息，仅限于发送给上面地址中列出<span
lang="EN-US"><br>
</span>的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、<span
lang="EN-US"><br>
</span>或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本<span
lang="EN-US"><br>
</span>邮件！<span lang="EN-US"><br>
</span></span></tt><tt><span style="font-size: 7.5pt; color:
gray;" lang="EN-US">This e-mail and its attachments contain
confidential information from H3C, which is
<br>
intended only for the person or entity whose address is listed
above. Any use of the
<br>
information contained herein in any way (including, but not
limited to, total or partial
<br>
disclosure, reproduction, or dissemination) by persons other
than the intended <br>
recipient(s) is prohibited. If you receive this e-mail in
error, please notify the sender
<br>
by phone or email immediately and delete it!</span></tt><tt>
</tt><tt><br>
</tt>
<fieldset class="mimeAttachmentHeader"></fieldset>
<tt><br>
</tt>
<pre wrap="">_______________________________________________
Ocfs2-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Ocfs2-devel@oss.oracle.com">Ocfs2-devel@oss.oracle.com</a>
<a class="moz-txt-link-freetext" href="https://oss.oracle.com/mailman/listinfo/ocfs2-devel">https://oss.oracle.com/mailman/listinfo/ocfs2-devel</a></pre>
</blockquote>
<tt><br>
</tt>
</body>
</html>