<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=gb2312">
<style>body { line-height: 1.5; }blockquote { margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em; }div.foxdiv20150630112547438084 { }body { font-size: 16pt; font-family: 微软雅黑; color: rgb(0, 0, 0); line-height: 1.5; }</style>
</head>
<body>
<div><span></span></div>
<blockquote style="margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em;">
<div>
<div class="FoxDiv20150630112547438084">
<blockquote style="margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em;">
<div class="FoxDiv20150630111601972229">
<blockquote style="margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em;">
<div class="FoxDiv20150630100730998087">
<div style="font-size:16px">Hi</div>
<div style="font-size:16px"><br>
</div>
<div style="font-size:16px">1. In the callback o2net_sendpage -> sendpage<span style="line-height:1.5">()</span></div>
<div style="font-size:16px"><span style="line-height:1.5">2. I</span><span style="line-height:1.5">f </span>sendpage<span style="line-height:1.5"> (tcp</span><span style="line-height:1.5"> socket send) continuously returns </span><span style="line-height:1.5">-EAGAIN</span><span style="line-height:1.5">,
t</span><span style="line-height:1.5">hen </span><span style="line-height:1.5">get into an endless
</span><span style="line-height:1.5">loop,</span></div>
<div style="font-size:16px"><span style="line-height:1.5"> </span><span style="line-height:1.5">even though </span><span style="line-height:1.5">the function of
</span><span style="line-height:1.5">cond_resched() </span><span style="line-height:1.5">have </span><span style="line-height:1.5">already </span><span style="line-height:1.5">used</span><span style="line-height:1.5">.</span></div>
<div style="font-size:16px"><span style="line-height:1.5">3. I think it is not reasonable, </span><span style="line-height:1.5">try to </span><span style="line-height:1.5">continuously </span><span style="line-height:1.5">send </span><span style="line-height:1.5">20
times </span><span style="line-height:1.5">returns </span><span style="line-height:1.5">-EAGAIN</span><span style="line-height:1.5"> ,</span></div>
<div style="font-size:16px"><span style="line-height:1.5"> </span><span style="line-height:1.5">shutdown the socket to avoid
</span><span style="line-height:1.5">affecting </span><span style="line-height:1.5">the </span><span style="line-height:1.5">entire </span><span style="line-height:1.5">cluster.</span></div>
<div style="font-size:16px"><span style="line-height:1.5"><br>
</span></div>
<div style="font-size:16px"><span style="line-height:1.5; background-color:window">Finally, any feedback about this process
</span><span style="line-height:1.5; background-color:window">(positive or negative) would be greatly appreciated.</span></div>
<div>
<pre style="font-size: 16px;"><span style="font-family: monospace; background-color: rgba(0, 0, 0, 0);">--- tcp.c 2015-06-30 11:46:54.727447919 +0800<br>+++ tcp.c.diff 2015-06-30 11:52:12.823447881 +0800<br>@@ -949,6 +949,7 @@<br> {<br> struct o2net_node *nn = o2net_nn_from_num(sc->sc_node->nd_num);<br> ssize_t ret;<br>+ int send_fails = 20;<br> <br> while (1) {<br> mutex_lock(&sc->sc_send_lock);<br>@@ -959,10 +960,11 @@<br> mutex_unlock(&sc->sc_send_lock);<br> if (ret == size)<br> break;<br>- if (ret == (ssize_t)-EAGAIN) {<br>+ if (ret == (ssize_t)-EAGAIN && send_fails > 0) {<br> mlog(0, "sendpage of size %zu to " SC_NODEF_FMT<br> " returned EAGAIN\n", size, SC_NODEF_ARGS(sc));<br> cond_resched();<br>+ --send_fails;<br> continue;<br> }<br> mlog(ML_ERROR, "sendpage of size %zu to " SC_NODEF_FMT</span></pre>
<pre><font face="微软雅黑" size="4"><span style="background-color: rgb(255, 255, 255);">syslog:</span></font></pre>
<pre style="font-size: 16px;"><span style="font-family: 微软雅黑; line-height: 1.5; background-color: window;">/var/log/syslog:Jun 29 09:32:58 cvk47 kernel: [156022.769539] (kworker/u130:1,12041,9):o2net_sendpage:1026 sendpage of size 24 to node cvk61 (num 5) at 172.16.202.61:7100 returned EAGAINne</span></pre>
<pre style="font-size: 16px;"><span><font face="微软雅黑">/var/log/syslog:Jun 29 09:32:58 cvk47 kernel: [156022.769542] (kworker/u130:1,12041,9):o2net_sendpage:1026 sendpage of size 24 to node cvk61 (num 5) at 172.16.202.61:7100 returned EAGAINne<br>/var/log/syslog:Jun 29 09:32:58 cvk47 kernel: [156022.769544] (kworker/u130:1,12041,9):o2net_sendpage:1026 sendpage of size 24 to node cvk61 (num 5) at 172.16.202.61:7100 returned EAGAINne<br>/var/log/syslog:Jun 29 09:32:58 cvk47 kernel: [156022.769546] (kworker/u130:1,12041,9):o2net_sendpage:1026 sendpage of</font></span></pre>
</div>
<hr color="#b5c4df" size="1" align="left" style="width:210px; height:1px; font-size:16px">
<div><span>
<div style="margin:10px; font-size:10pt">
<div style="font-size:16px">zhangguanghui 10102</div>
</div>
</span></div>
</div>
</blockquote>
</div>
</blockquote>
<span style="font-size:7.5pt; font-family:华文细黑; color:gray"><span lang="EN-US">-------------------------------------------------------------------------------------------------------------------------------------<br>
</span>本邮件及其附件含有杭州华三通信技术有限公司的保密信息，仅限于发送给上面地址中列出<span lang="EN-US"><br>
</span>的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、<span lang="EN-US"><br>
</span>或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本<span lang="EN-US"><br>
</span>邮件！<span lang="EN-US"><br>
</span></span><span lang="EN-US" style="font-size:7.5pt; font-family:"Arial","sans-serif"; color:gray">This e-mail and its attachments contain confidential information from H3C, which is
<br>
intended only for the person or entity whose address is listed above. Any use of the
<br>
information contained herein in any way (including, but not limited to, total or partial
<br>
disclosure, reproduction, or dissemination) by persons other than the intended <br>
recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender
<br>
by phone or email immediately and delete it!</span> </div>
</div>
</blockquote>
</body>
</html>