<p dir="ltr">Hi, Richard.</p>
<p dir="ltr">Thanks for reply.<br>
Ok. I will keep trying to set the environment for verifying my paches.<br>
But, before I said, it takes some time... Setting this filesystem in my machine with qemu is too hard for me. :(</p>
<p dir="ltr">Regards,<br>
Daeseok Youn.</p>
<p dir="ltr">2015. 3. 13. 오후 5:16에 "Richard Weinberger" <<a href="mailto:richard@nod.at">richard@nod.at</a>>님이 작성:<br>
><br>
> Am 13.03.2015 um 04:59 schrieb DaeSeok Youn:<br>
> > Hi,<br>
> ><br>
> > This patch have been pending for 2 weeks.<br>
> > Do I need to check other things?<br>
> ><br>
> > please, check for me.<br>
><br>
> I cannot speak for OCFS2 folks. But maybe you can give them a<br>
> better feeling if you proof that your patch is tested.<br>
><br>
> Thanks,<br>
> //richard<br>
><br>
> > Thanks!<br>
> ><br>
> > regards,<br>
> > Daeseok Youn<br>
> ><br>
> > 2015-02-28 8:48 GMT+09:00 Daeseok Youn <<a href="mailto:daeseok.youn@gmail.com">daeseok.youn@gmail.com</a>>:<br>
> >> The use of 'status' in __ocfs2_add_entry() can return wrong<br>
> >> status when some functions are failed.<br>
> >><br>
> >> If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed,<br>
> >> that status is saved to 'status' but return variable is 'retval'<br>
> >> which is saved 'success' status. In case of this, __ocfs2_add_entry()<br>
> >> is failed but can be returned as 'success'.<br>
> >><br>
> >> So replace 'status' with 'retval'.<br>
> >><br>
> >> Signed-off-by: Daeseok Youn <<a href="mailto:daeseok.youn@gmail.com">daeseok.youn@gmail.com</a>><br>
> >> ---<br>
> >> V2 : update changelog<br>
> >><br>
> >> fs/ocfs2/dir.c | 12 ++++++------<br>
> >> 1 files changed, 6 insertions(+), 6 deletions(-)<br>
> >><br>
> >> diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c<br>
> >> index b08050b..1478a50 100644<br>
> >> --- a/fs/ocfs2/dir.c<br>
> >> +++ b/fs/ocfs2/dir.c<br>
> >> @@ -1617,7 +1617,7 @@ int __ocfs2_add_entry(handle_t *handle,<br>
> >> struct ocfs2_dir_entry *de, *de1;<br>
> >> struct ocfs2_dinode *di = (struct ocfs2_dinode *)parent_fe_bh->b_data;<br>
> >> struct super_block *sb = dir->i_sb;<br>
> >> - int retval, status;<br>
> >> + int retval;<br>
> >> unsigned int size = sb->s_blocksize;<br>
> >> struct buffer_head *insert_bh = lookup->dl_leaf_bh;<br>
> >> char *data_start = insert_bh->b_data;<br>
> >> @@ -1695,22 +1695,22 @@ int __ocfs2_add_entry(handle_t *handle,<br>
> >> }<br>
> >><br>
> >> if (insert_bh == parent_fe_bh)<br>
> >> - status = ocfs2_journal_access_di(handle,<br>
> >> + retval = ocfs2_journal_access_di(handle,<br>
> >> INODE_CACHE(dir),<br>
> >> insert_bh,<br>
> >> OCFS2_JOURNAL_ACCESS_WRITE);<br>
> >> else {<br>
> >> - status = ocfs2_journal_access_db(handle,<br>
> >> + retval = ocfs2_journal_access_db(handle,<br>
> >> INODE_CACHE(dir),<br>
> >> insert_bh,<br>
> >> OCFS2_JOURNAL_ACCESS_WRITE);<br>
> >><br>
> >> if (ocfs2_dir_indexed(dir)) {<br>
> >> - status = ocfs2_dx_dir_insert(dir,<br>
> >> + retval = ocfs2_dx_dir_insert(dir,<br>
> >> handle,<br>
> >> lookup);<br>
> >> - if (status) {<br>
> >> - mlog_errno(status);<br>
> >> + if (retval) {<br>
> >> + mlog_errno(retval);<br>
> >> goto bail;<br>
> >> }<br>
> >> }<br>
> >> --<br>
> >> 1.7.1<br>
> >><br>
</p>