<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Guozhonghua, idea of the fix looks
good, but the patch doesn't seem to meet mainline standards. Can
you please follow the instructions that Jeff emailed you last time
and resubmit the patch.<br>
<br>
On 03/11/2014 04:09 AM, Guozhonghua wrote:<br>
</div>
<blockquote
cite="mid:71604351584F6A4EBAE558C676F37CA42EC3CCB9@H3CMLB02-EX.srv.huawei-3com.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<style>
<!--
@font-face
{font-family:SimSun}
@font-face
{font-family:SimSun}
@font-face
{font-family:Calibri}
@font-face
{font-family:SimSun}
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
text-align:justify;
text-justify:inter-ideograph;
font-size:10.5pt;
font-family:"Calibri","sans-serif"}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline}
a:visited, span.MsoHyperlinkFollowed
{color:purple;
text-decoration:underline}
span.EmailStyle17
{font-family:"Calibri","sans-serif";
color:windowtext}
.MsoChpDefault
{}
@page WordSection1
{margin:72.0pt 90.0pt 72.0pt 90.0pt}
div.WordSection1
{}
-->
</style>
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">I review the code of the
kernel 3.11.10.</span></p>
<p class="MsoNormal"><span lang="EN-US"> </span></p>
<p class="MsoNormal"><span lang="EN-US">The difference is as
below: </span></p>
<p class="MsoNormal"><span lang="EN-US"> </span></p>
<p class="MsoNormal"><span lang="EN-US">--
../linux-3.11.10/fs/ocfs2/dlm/dlmdomain.c 2013-11-30
02:42:37.000000000 +0800</span></p>
<p class="MsoNormal"><span lang="EN-US">+++
ocfs2-ko-3.11/dlm/dlmdomain.c 2014-03-11
18:57:23.323897515 +0800</span></p>
<p class="MsoNormal"><span lang="EN-US">@@ -1135,6 +1135,9 @@
static int dlm_query_region_handler(stru</span></p>
<p class="MsoNormal"><span lang="EN-US"> int status = 0;</span></p>
<p class="MsoNormal"><span lang="EN-US"> int locked = 0;</span></p>
<p class="MsoNormal"><span lang="EN-US"></span></p>
<p class="MsoNormal"><span lang="EN-US">+ /* Wether domain
locked */</span></p>
</div>
</blockquote>
comment probably not required <br>
<blockquote
cite="mid:71604351584F6A4EBAE558C676F37CA42EC3CCB9@H3CMLB02-EX.srv.huawei-3com.com"
type="cite">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">+ int domain_locked =
0;</span></p>
<p class="MsoNormal"><span lang="EN-US">+</span></p>
<p class="MsoNormal"><span lang="EN-US"> qr = (struct
dlm_query_region *) msg->buf;</span></p>
<p class="MsoNormal"><span lang="EN-US"></span></p>
<p class="MsoNormal"><span lang="EN-US"> mlog(0, "Node %u
queries hb regions on domain %s\n", qr->qr_node,</span></p>
<p class="MsoNormal"><span lang="EN-US">@@ -1150,6 +1153,7 @@
static int dlm_query_region_handler(stru</span></p>
<p class="MsoNormal"><span lang="EN-US"> status = -EINVAL;</span></p>
<p class="MsoNormal"><span lang="EN-US"></span></p>
<p class="MsoNormal"><span lang="EN-US">
spin_lock(&dlm_domain_lock);</span></p>
<p class="MsoNormal"><span lang="EN-US">+ domain_locked = 1;</span></p>
<p class="MsoNormal"><span lang="EN-US"> dlm =
__dlm_lookup_domain_full(qr->qr_domain,
qr->qr_namelen);</span></p>
<p class="MsoNormal"><span lang="EN-US"> if (!dlm) {</span></p>
<p class="MsoNormal"><span lang="EN-US">
mlog(ML_ERROR, "Node %d queried hb regions on domain %s "</span></p>
<p class="MsoNormal"><span lang="EN-US">@@ -1181,9 +1185,12 @@
static int dlm_query_region_handler(stru</span></p>
<p class="MsoNormal"><span lang="EN-US">bail:</span></p>
<p class="MsoNormal"><span lang="EN-US"> if (locked)</span></p>
<p class="MsoNormal"><span lang="EN-US">
spin_unlock(&dlm->spinlock);</span></p>
<p class="MsoNormal"><span lang="EN-US">-
spin_unlock(&dlm_domain_lock);</span></p>
<p class="MsoNormal"><span lang="EN-US"></span></p>
<p class="MsoNormal"><span lang="EN-US">- kfree(local);</span></p>
<p class="MsoNormal"><span lang="EN-US">+ if (domain_locked)</span></p>
<p class="MsoNormal"><span lang="EN-US">+
spin_unlock(&dlm_domain_lock);</span></p>
<p class="MsoNormal"><span lang="EN-US">+ </span></p>
<p class="MsoNormal"><span lang="EN-US">+ if (local)</span></p>
<p class="MsoNormal"><span lang="EN-US">+ kfree(local);</span></p>
</div>
</blockquote>
no need to check if (local), kfree will take care of that part<br>
<blockquote
cite="mid:71604351584F6A4EBAE558C676F37CA42EC3CCB9@H3CMLB02-EX.srv.huawei-3com.com"
type="cite">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US"></span></p>
<p class="MsoNormal"><span lang="EN-US"> return status;</span></p>
<p class="MsoNormal"><span lang="EN-US">}</span></p>
</div>
<span style="font-size:7.5pt; font-family:华文细黑; color:gray"><span
lang="EN-US">-------------------------------------------------------------------------------------------------------------------------------------<br>
</span>本邮件及其附件含有杭州华三通信技术有限公司的保密信息，仅限于发送给上面地址中列出<span
lang="EN-US"><br>
</span>的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、<span
lang="EN-US"><br>
</span>或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本<span
lang="EN-US"><br>
</span>邮件！<span lang="EN-US"><br>
</span></span><span style="font-size:7.5pt;
font-family:"Arial","sans-serif";
color:gray" lang="EN-US">This e-mail and its attachments contain
confidential information from H3C, which is
<br>
intended only for the person or entity whose address is listed
above. Any use of the
<br>
information contained herein in any way (including, but not
limited to, total or partial
<br>
disclosure, reproduction, or dissemination) by persons other
than the intended <br>
recipient(s) is prohibited. If you receive this e-mail in error,
please notify the sender
<br>
by phone or email immediately and delete it!</span>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Ocfs2-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Ocfs2-devel@oss.oracle.com">Ocfs2-devel@oss.oracle.com</a>
<a class="moz-txt-link-freetext" href="https://oss.oracle.com/mailman/listinfo/ocfs2-devel">https://oss.oracle.com/mailman/listinfo/ocfs2-devel</a></pre>
</blockquote>
<br>
</body>
</html>