<div dir="ltr">You may want to do the same for the version file in dlm, dlmfs, etc.<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Nov 26, 2013 at 11:28 AM, Goldwyn Rodrigues <span dir="ltr"><<a href="mailto:rgoldwyn@suse.de" target="_blank">rgoldwyn@suse.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The versioning information is confusing for end-users. The numbers<br>
are stuck at 1.5.0 when the tools have moved to 1.8.3.<br>
<br>
I suggest removing the versioning system in the kernel altogether<br>
and let the kernel version be the guide to debug issues. However, if<br>
you think versioning is still required, please state the reason and<br>
modify the version string in the ver.* files to reflect the uptodate<br>
information.<br>
<br>
Signed-off-by: Goldwyn Rodrigues <<a href="mailto:rgoldwyn@suse.com">rgoldwyn@suse.com</a>><br>
---<br>
fs/ocfs2/Makefile | 1 -<br>
fs/ocfs2/super.c | 3 ---<br>
fs/ocfs2/ver.c | 43 -------------------------------------------<br>
fs/ocfs2/ver.h | 31 -------------------------------<br>
4 files changed, 78 deletions(-)<br>
delete mode 100644 fs/ocfs2/ver.c<br>
delete mode 100644 fs/ocfs2/ver.h<br>
<br>
diff --git a/fs/ocfs2/Makefile b/fs/ocfs2/Makefile<br>
index f17e58b..ce210d4 100644<br>
--- a/fs/ocfs2/Makefile<br>
+++ b/fs/ocfs2/Makefile<br>
@@ -38,7 +38,6 @@ ocfs2-objs := \<br>
symlink.o \<br>
sysfile.o \<br>
uptodate.o \<br>
- ver.o \<br>
quota_local.o \<br>
quota_global.o \<br>
xattr.o \<br>
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c<br>
index c414929..a4382d1 100644<br>
--- a/fs/ocfs2/super.c<br>
+++ b/fs/ocfs2/super.c<br>
@@ -68,7 +68,6 @@<br>
#include "super.h"<br>
#include "sysfile.h"<br>
#include "uptodate.h"<br>
-#include "ver.h"<br>
#include "xattr.h"<br>
#include "quota.h"<br>
#include "refcounttree.h"<br>
@@ -1618,8 +1617,6 @@ static int __init ocfs2_init(void)<br>
{<br>
int status, i;<br>
<br>
- ocfs2_print_version();<br>
-<br>
for (i = 0; i < OCFS2_IOEND_WQ_HASH_SZ; i++)<br>
init_waitqueue_head(&ocfs2__ioend_wq[i]);<br>
<br>
diff --git a/fs/ocfs2/ver.c b/fs/ocfs2/ver.c<br>
deleted file mode 100644<br>
index e2488f4..0000000<br>
--- a/fs/ocfs2/ver.c<br>
+++ /dev/null<br>
@@ -1,43 +0,0 @@<br>
-/* -*- mode: c; c-basic-offset: 8; -*-<br>
- * vim: noexpandtab sw=8 ts=8 sts=0:<br>
- *<br>
- * ver.c<br>
- *<br>
- * version string<br>
- *<br>
- * Copyright (C) 2002, 2005 Oracle. All rights reserved.<br>
- *<br>
- * This program is free software; you can redistribute it and/or<br>
- * modify it under the terms of the GNU General Public<br>
- * License as published by the Free Software Foundation; either<br>
- * version 2 of the License, or (at your option) any later version.<br>
- *<br>
- * This program is distributed in the hope that it will be useful,<br>
- * but WITHOUT ANY WARRANTY; without even the implied warranty of<br>
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU<br>
- * General Public License for more details.<br>
- *<br>
- * You should have received a copy of the GNU General Public<br>
- * License along with this program; if not, write to the<br>
- * Free Software Foundation, Inc., 59 Temple Place - Suite 330,<br>
- * Boston, MA 021110-1307, USA.<br>
- */<br>
-<br>
-#include <linux/module.h><br>
-#include <linux/string.h><br>
-#include <linux/kernel.h><br>
-<br>
-#include "ver.h"<br>
-<br>
-#define OCFS2_BUILD_VERSION "1.5.0"<br>
-<br>
-#define VERSION_STR "OCFS2 " OCFS2_BUILD_VERSION<br>
-<br>
-void ocfs2_print_version(void)<br>
-{<br>
- printk(KERN_INFO "%s\n", VERSION_STR);<br>
-}<br>
-<br>
-MODULE_DESCRIPTION(VERSION_STR);<br>
-<br>
-MODULE_VERSION(OCFS2_BUILD_VERSION);<br>
diff --git a/fs/ocfs2/ver.h b/fs/ocfs2/ver.h<br>
deleted file mode 100644<br>
index d7395cb..0000000<br>
--- a/fs/ocfs2/ver.h<br>
+++ /dev/null<br>
@@ -1,31 +0,0 @@<br>
-/* -*- mode: c; c-basic-offset: 8; -*-<br>
- * vim: noexpandtab sw=8 ts=8 sts=0:<br>
- *<br>
- * ver.h<br>
- *<br>
- * Function prototypes<br>
- *<br>
- * Copyright (C) 2002, 2004 Oracle. All rights reserved.<br>
- *<br>
- * This program is free software; you can redistribute it and/or<br>
- * modify it under the terms of the GNU General Public<br>
- * License as published by the Free Software Foundation; either<br>
- * version 2 of the License, or (at your option) any later version.<br>
- *<br>
- * This program is distributed in the hope that it will be useful,<br>
- * but WITHOUT ANY WARRANTY; without even the implied warranty of<br>
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU<br>
- * General Public License for more details.<br>
- *<br>
- * You should have received a copy of the GNU General Public<br>
- * License along with this program; if not, write to the<br>
- * Free Software Foundation, Inc., 59 Temple Place - Suite 330,<br>
- * Boston, MA 021110-1307, USA.<br>
- */<br>
-<br>
-#ifndef OCFS2_VER_H<br>
-#define OCFS2_VER_H<br>
-<br>
-void ocfs2_print_version(void);<br>
-<br>
-#endif /* OCFS2_VER_H */<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.1.4<br>
<br>
<br>
--<br>
Goldwyn<br>
<br>
_______________________________________________<br>
Ocfs2-devel mailing list<br>
<a href="mailto:Ocfs2-devel@oss.oracle.com">Ocfs2-devel@oss.oracle.com</a><br>
<a href="https://oss.oracle.com/mailman/listinfo/ocfs2-devel" target="_blank">https://oss.oracle.com/mailman/listinfo/ocfs2-devel</a><br>
</font></span></blockquote></div><br></div>