<div dir="ltr">Acked-by: Sunil Mushran <<a href="mailto:sunil.mushran@gmail.com">sunil.mushran@gmail.com</a>><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 21, 2013 at 7:44 PM, shencanquan <span dir="ltr"><<a href="mailto:shencanquan@huawei.com" target="_blank">shencanquan@huawei.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 2013/5/22 10:38, <a href="http://xiaowei.hu" target="_blank">xiaowei.hu</a> wrote:<br>
> if there is error happen in , for example EIO in<br>
> __ocfs2_prepare_orphan_dir, ocfs2_prep_new_orphaned_file will release<br>
> the inode_ac, the the caller of ocfs2_prep_new_orphaned_file get a 0<br>
> return, it will refer to a NULL ocfs2_alloc_context struct in the<br>
> following functions.Kernel panic happens.<br>
</div>Hmm, I see, this patch looks good .<br>
Reviewed-by: shencanquan <<a href="mailto:shencanquan@huawei.com">shencanquan@huawei.com</a>><br>
<div class="HOEnZb"><div class="h5">><br>
> On 05/22/2013 10:31 AM, shencanquan wrote:<br>
>> if return 0, what's wrong with this?<br>
>> On 2013/5/22 9:43, <a href="mailto:xiaowei.hu@oracle.com">xiaowei.hu@oracle.com</a> wrote:<br>
>>> From: "Xiaowei.Hu"<<a href="mailto:xiaowei.hu@oracle.com">xiaowei.hu@oracle.com</a>><br>
>>><br>
>>> ---<br>
>>> fs/ocfs2/namei.c | 2 +-<br>
>>> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
>>><br>
>>> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c<br>
>>> index 50c93a8..422cbe0 100644<br>
>>> --- a/fs/ocfs2/namei.c<br>
>>> +++ b/fs/ocfs2/namei.c<br>
>>> @@ -2216,7 +2216,7 @@ out:<br>
>>><br>
>>> brelse(orphan_dir_bh);<br>
>>><br>
>>> - return 0;<br>
>>> + return ret;<br>
>>> }<br>
>>><br>
>>> int ocfs2_create_inode_in_orphan(struct inode *dir,<br>
>><br>
>><br>
><br>
><br>
><br>
<br>
<br>
<br>
_______________________________________________<br>
Ocfs2-devel mailing list<br>
<a href="mailto:Ocfs2-devel@oss.oracle.com">Ocfs2-devel@oss.oracle.com</a><br>
<a href="https://oss.oracle.com/mailman/listinfo/ocfs2-devel" target="_blank">https://oss.oracle.com/mailman/listinfo/ocfs2-devel</a><br>
</div></div></blockquote></div><br></div>