<div dir="ltr">Acked-by: Sunil Mushran <<a href="mailto:sunil.mushran@gmail.com">sunil.mushran@gmail.com</a>><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 14, 2013 at 12:08 AM, Joseph Qi <span dir="ltr"><<a href="mailto:joseph.qi@huawei.com" target="_blank">joseph.qi@huawei.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Last time we found there is a lock/unlock bug in ocfs2_file_aio_write,<br>
and then we did a thoroughly search for all lock resources in<br>
ocfs2_inode_info, including rw, inode and open lockres and found this<br>
bug.<br>
My kernel version is 3.0.13, and it is also in the lastest version 3.9.<br>
In ocfs2_fiemap, once ocfs2_get_clusters_nocache failed, it should goto<br>
out_unlock instead of out, because we need release buffer head, up read<br>
alloc sem and unlock inode.<br>
<br>
Cc: <a href="mailto:stable@vger.kernel.org">stable@vger.kernel.org</a><br>
Signed-off-by: Joseph Qi <<a href="mailto:joseph.qi@huawei.com">joseph.qi@huawei.com</a>><br>
Reviewed-by: Jie Liu <<a href="mailto:jeff.liu@oracle.com">jeff.liu@oracle.com</a>><br>
<br>
---<br>
fs/ocfs2/extent_map.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/fs/ocfs2/extent_map.c b/fs/ocfs2/extent_map.c<br>
index 1c39efb..2487116 100644<br>
--- a/fs/ocfs2/extent_map.c<br>
+++ b/fs/ocfs2/extent_map.c<br>
@@ -790,7 +790,7 @@ int ocfs2_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,<br>
&hole_size, &rec, &is_last);<br>
if (ret) {<br>
mlog_errno(ret);<br>
- goto out;<br>
+ goto out_unlock;<br>
}<br>
<br>
if (rec.e_blkno == 0ULL) {<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.7.9.7<br>
<br>
<br>
_______________________________________________<br>
Ocfs2-devel mailing list<br>
<a href="mailto:Ocfs2-devel@oss.oracle.com">Ocfs2-devel@oss.oracle.com</a><br>
<a href="https://oss.oracle.com/mailman/listinfo/ocfs2-devel" target="_blank">https://oss.oracle.com/mailman/listinfo/ocfs2-devel</a><br>
</font></span></blockquote></div><br></div>