NAK.<div><br></div><div>hb_task is a local variable that is not even accessed after kthread_stop().</div><div>The oops is in kthread_stop(). Points to a problem with get/put in task_struct.</div><div>Not an ocfs2 issue.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Dec 3, 2012 at 7:18 PM, <span dir="ltr"><<a href="mailto:xiaowei.hu@oracle.com" target="_blank">xiaowei.hu@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
From: "Xiaowei.Hu" <<a href="mailto:xiaowei.hu@oracle.com">xiaowei.hu@oracle.com</a>><br>
<br>
Pid: 4508, comm:<br>
mkfs.ocfs2 Not tainted 2.6.39-300.17.1.el5uek.bug14842737<br>
#1 Dell Inc. PowerEdge 1950/0M788G RIP:<br>
0010:[<ffffffff81098bff>] [<ffffffff81098bff>]<br>
exit_creds+0x1f/0xb0 RSP: 0018:ffff880222b4dd58 EFLAGS:<br>
00010292 RAX: 0000000000000000 RBX: ffff88021f394480 RCX:<br>
ffff88021f1f2d90 RDX: 0000000000000013 RSI:<br>
ffff88021e9c4a00 RDI: 0000000000000000 RBP:<br>
ffff880222b4dd68 R08: 0000000000000003 R09:<br>
0000000000000020 R10: ffff880222b4dd18 R11:<br>
0000000000000001 R12: ffff88021f394480 R13:<br>
ffffffffa065ca88 R14: ffff88021e9c4a00 R15:<br>
ffff88021e9c4a00 FS: 00007fa5e950c730(0000)<br>
GS:ffff88022fcc0000(0000) knlGS:0000000000000000 CS: 0010<br>
DS: 0000 ES: 0000 CR0: 0000000080050033 CR2:<br>
0000000000000000 CR3: 000000021e166000 CR4:<br>
00000000000006e0 DR0: 0000000000000000 DR1:<br>
0000000000000000 DR2: 0000000000000000 DR3:<br>
0000000000000000 DR6: 00000000ffff0ff0 DR7:<br>
0000000000000400 Process mkfs.ocfs2 (pid: 4508, threadinfo<br>
ffff880222b4c000, task ffff88022024c4c0) Stack:<br>
ffff880222b4dd88 ffff88021f394480 ffff880222b4dd88<br>
ffffffff8106e802 ffff88021f394480 0000000000000000<br>
ffff880222b4dda8 ffffffff81090c38 ffff88021f394480<br>
ffff88021e9c4a00 ffff880222b4dde8 ffffffffa064b78d Call<br>
Trace: [<ffffffff8106e802>] __put_task_struct+0x42/0x100<br>
[<ffffffff81090c38>] kthread_stop+0x78/0xd0<br>
[<ffffffffa064b78d>]<br>
o2hb_heartbeat_group_drop_item+0x6d/0x1d0<br>
[ocfs2_nodemanager] [<ffffffffa0635136>]<br>
client_drop_item+0x26/0x40 [configfs] [<ffffffffa063650e>]<br>
configfs_rmdir+0x20e/0x2c0 [configfs] [<ffffffff81186c08>]<br>
? shrink_dcache_parent+0x38/0x50 [<ffffffff8117b55b>]<br>
vfs_rmdir+0xdb/0x130 [<ffffffff8117eb0b>]<br>
do_rmdir+0x10b/0x120 [<ffffffff810cf78b>] ?<br>
audit_syscall_entry+0x17b/0x1e0 [<ffffffff8117eb76>]<br>
sys_rmdir+0x16/0x20 [<ffffffff81510642>]<br>
system_call_fastpath+0x16/0x1b Code: 80 00 00 00 00 0f 1f<br>
80 00 00 00 00 55 48 89 e5 53 48 83 ec 08 66 66 66 66 90 48<br>
8b 87 30 06 00 00 48 89 fb 48 8b bf 28 06 00 00 <8b> 00 48<br>
c7 83 28 06 00 00 00 00 00 00 f0 ff 0f 0f 94 c0 84 c0 RIP<br>
[<ffffffff81098bff>] exit_creds+0x1f/0xb0 RSP<br>
<ffff880222b4dd58> CR2: 0000000000000000<br>
<br>
---<br>
fs/ocfs2/cluster/heartbeat.c | 4 +++-<br>
1 files changed, 3 insertions(+), 1 deletions(-)<br>
<br>
diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c<br>
index 61561c6..94193ac 100644<br>
--- a/fs/ocfs2/cluster/heartbeat.c<br>
+++ b/fs/ocfs2/cluster/heartbeat.c<br>
@@ -2143,8 +2143,10 @@ static void o2hb_heartbeat_group_drop_item(struct config_group *group,<br>
reg->hr_item_dropped = 1;<br>
spin_unlock(&o2hb_live_lock);<br>
<br>
- if (hb_task)<br>
+ if (hb_task) {<br>
kthread_stop(hb_task);<br>
+ hb_task = NULL;<br>
+ }<br>
<br>
if (o2hb_global_heartbeat_active()) {<br>
spin_lock(&o2hb_live_lock);<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.7.7.6<br>
<br>
<br>
_______________________________________________<br>
Ocfs2-devel mailing list<br>
<a href="mailto:Ocfs2-devel@oss.oracle.com">Ocfs2-devel@oss.oracle.com</a><br>
<a href="https://oss.oracle.com/mailman/listinfo/ocfs2-devel" target="_blank">https://oss.oracle.com/mailman/listinfo/ocfs2-devel</a><br>
</font></span></blockquote></div><br></div>