The patch is not in mainline. I am putting together a branch for Joel to pull.<br><br><div class="gmail_quote">On Thu, Aug 9, 2012 at 5:22 AM, Dan Carpenter <span dir="ltr"><<a href="mailto:dan.carpenter@oracle.com" target="_blank">dan.carpenter@oracle.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is still here. I'm not sure why this error message just showed<br>
up in linux-next again. Odd.<br>
<br>
regards,<br>
dan carpenter<br>
<br>
On Tue, Aug 30, 2011 at 02:14:04PM -0700, Sunil Mushran wrote:<br>
> Thanks. I'll fix the two.<br>
><br>
> On 08/25/2011 06:01 PM, Dan Carpenter wrote:<br>
> >Hello Sunil Mushran,<br>
> ><br>
> >1dfecf810e0e: "ocfs2/cluster: Clean up messages in o2net"<br>
> >Leads to the following Smatch complaint:<br>
> >fs/ocfs2/cluster/tcp.c +1704 o2net_start_connect(101)<br>
> > error: we previously assumed 'sc' could be null (see line 1650)<br>
> ><br>
> >fs/ocfs2/cluster/tcp.c<br>
> > 1649 sc = sc_alloc(node);<br>
> > 1650 if (sc == NULL) {<br>
> > 1651 mlog(0, "couldn't allocate sc\n");<br>
> > 1652 ret = -ENOMEM;<br>
> > 1653 goto out;<br>
> > 1654 }<br>
> > 1655<br>
> ><br>
> >--- [snip] ---<br>
> ><br>
> > 1701 out:<br>
> > 1702 if (ret) {<br>
> > 1703 printk(KERN_NOTICE "o2net: Connect attempt to " SC_NODEF_FMT<br>
> > 1704 " failed with errno %d\n", SC_NODEF_ARGS(sc), ret);<br>
> > ^^<br>
> >Null dereference here.<br>
> ><br>
> > 1705 /* 0 err so that another will be queued and attempted<br>
> > 1706 * from set_nn_state */<br>
> ><br>
> >This email is from my new semi-automatic bug reporting tool script.<br>
> >Btw, Smatch complains about this as well:<br>
> ><br>
> >fs/ocfs2/cluster/tcp.c +549 o2net_set_nn_state(44)<br>
> > error: we previously assumed 'old_sc' could be null (see line 517)<br>
> ><br>
> >These dereferences were disabled in my old config, but Smatch detects<br>
> >them now that we're using normal printk()<br>
> ><br>
> >regards,<br>
> >dan carpenter<br>
<br>
_______________________________________________<br>
Ocfs2-devel mailing list<br>
<a href="mailto:Ocfs2-devel@oss.oracle.com">Ocfs2-devel@oss.oracle.com</a><br>
<a href="https://oss.oracle.com/mailman/listinfo/ocfs2-devel" target="_blank">https://oss.oracle.com/mailman/listinfo/ocfs2-devel</a><br>
</blockquote></div><br>