<div class="gmail_quote">On Mon, Aug 13, 2012 at 7:03 PM, Xue jiufei <span dir="ltr"><<a href="mailto:xuejiufei@huawei.com" target="_blank">xuejiufei@huawei.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
A parallel umount on 4 nodes triggered a bug in dlm_process_recovery_date(). Here’s the situation:<br>
Receiving MIG_LOCKRES message, A node processes the locks in migratable lockres. It copys lvb from migratable lockres when processing the first valid lock.<br>
If there is a lock in the blocked list with the EX level, it triggers the BUG. Since valid lvbs are set when locks are granted with EX or PR levels, locks in<br>
the blocked list cannot have valid lvbs. Therefore I think we should skip the locks in the blocked list.<br>
<br>
Signed-off-by: Xuejiufei <<a href="mailto:xuejiufei@huawei.com">xuejiufei@huawei.com</a>><br>
---<br>
fs/ocfs2/dlm/dlmrecovery.c | 7 +++++++<br>
1 file changed, 7 insertions(+)<br>
<br>
diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c<br>
index 01ebfd0..15d81ad 100644<br>
--- a/fs/ocfs2/dlm/dlmrecovery.c<br>
+++ b/fs/ocfs2/dlm/dlmrecovery.c<br>
@@ -1887,6 +1887,13 @@ static int dlm_process_recovery_data(struct dlm_ctxt *dlm,<br>
<br>
if (ml->type == LKM_NLMODE)<br>
goto skip_lvb;<br>
+<br>
+ /*<br>
+ * If the lock is in the blocked list it can't have a valid lvb,<br>
+ * so skip it<br>
+ */<br>
+ if (ml->list == DLM_BLOCKED_LIST)<br>
+ goto skip_lvb;<br>
<br>
if (!dlm_lvb_is_empty(mres->lvb)) {<br>
if (lksb->flags & DLM_LKSB_PUT_LVB) {<br>
<span class="HOEnZb"><font color="#888888">--<br></font></span></blockquote><div><br></div><div>Looks reasonable. </div><div><br></div><div>Just wanted to confirm. Did this BUG_ON in dlmrecovery,c get tripped?</div><div>
<br></div><div><div>1903 /* otherwise, the node is sending its</div><div>1904 * most recent valid lvb info */</div><div>1905 BUG_ON(ml->type != LKM_EXMODE &&</div>
<div>1906 ml->type != LKM_PRMODE);</div></div><div><br></div></div>