<div class="gmail_quote">On Wed, Jul 11, 2012 at 1:51 AM, Joel Becker <span dir="ltr"><<a href="mailto:jlbec@evilplan.org" target="_blank">jlbec@evilplan.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Wed, Jul 11, 2012 at 02:49:56PM +0800, Junxiao Bi wrote:<br>
> Signed-off-by: Junxiao Bi <<a href="mailto:junxiao.bi@oracle.com">junxiao.bi@oracle.com</a>><br>
> ---<br>
> fs/ocfs2/dlm/dlmmaster.c | 4 +++-<br>
> 1 file changed, 3 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c<br>
> index 005261c..1fadc39 100644<br>
> --- a/fs/ocfs2/dlm/dlmmaster.c<br>
> +++ b/fs/ocfs2/dlm/dlmmaster.c<br>
> @@ -1888,8 +1888,10 @@ ok:<br>
> * up nodes that this node contacted */<br>
> while ((nn = find_next_bit (mle->response_map, O2NM_MAX_NODES,<br>
> nn+1)) < O2NM_MAX_NODES) {<br>
> - if (nn != dlm->node_num && nn != assert->node_idx)<br>
> + if (nn != dlm->node_num && nn != assert->node_idx) {<br>
> master_request = 1;<br>
> + break;<br>
> + }<br>
<br>
</div> Seems like this will save a tiny bit of CPU in the assert master<br>
handler. Sunil, can you see any problem?<br>
<br></blockquote><div><br></div><div>Looks good to me. ACK. </div></div>