[Ocfs2-devel] [PATCH] ocfs2: reduce ioctl stack usage

Mark Fasheh mark at fasheh.com
Tue Apr 18 02:29:55 UTC 2023


On Mon, Apr 17, 2023 at 1:56 PM Arnd Bergmann <arnd at kernel.org> wrote:
> On 32-bit architectures with KASAN_STACK enabled, the total stack usage
> of the ocfs2_ioctl function grows beyond the warning limit:
>
> fs/ocfs2/ioctl.c: In function 'ocfs2_ioctl':
> fs/ocfs2/ioctl.c:934:1: error: the frame size of 1448 bytes is larger than 1400 bytes [-Werror=frame-larger-than=]
>
> Move each of the variables into a basic block, and mark ocfs2_info_handle()
> as noinline_for_stack, in order to have the variable share stack slots.

Thanks for this,

Reviewed-by: Mark Fasheh <mark at fasheh.com>
  --Mark



More information about the Ocfs2-devel mailing list