[Ocfs2-devel] [PATCH] ocfs2/xattr: Fix a bug when inserting xattr.
Tao Ma
tao.ma at oracle.com
Fri Sep 19 07:16:34 PDT 2008
During the process of xatt insertion, we use binary search
to find the right place and "low" is set to it. But when
there is one xattr which has the same name hash as the inserted
one, low is the wrong value. So set it to the right position.
Signed-off-by: Tao Ma <tao.ma at oracle.com>
---
fs/ocfs2/xattr.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c
index e65c8ac..584aef8 100644
--- a/fs/ocfs2/xattr.c
+++ b/fs/ocfs2/xattr.c
@@ -4029,8 +4029,10 @@ static void ocfs2_xattr_set_entry_normal(struct inode *inode,
else if (name_hash <
le32_to_cpu(tmp_xe->xe_name_hash))
high = tmp - 1;
- else
+ else {
+ low = tmp;
break;
+ }
}
xe = &xh->xh_entries[low];
--
1.5.4.GIT
More information about the Ocfs2-devel
mailing list