[Ocfs2-commits] mfasheh commits r2335 - trunk/fs/ocfs2

svn-commits at oss.oracle.com svn-commits at oss.oracle.com
Fri May 27 23:24:17 CDT 2005


Author: mfasheh
Signed-off-by: manish
Date: 2005-05-27 23:24:15 -0500 (Fri, 27 May 2005)
New Revision: 2335

Modified:
   trunk/fs/ocfs2/journal.c
Log:
* during error cleanup of ocfs_start_trans, we call
  ocfs_commit_unstarted_handle() which will kfree the handle for us, but we
  then kfree it again afterwards. Remove the redundant kfree. This fixes
  bugzilla #366

Signed-off-by: manish



Modified: trunk/fs/ocfs2/journal.c
===================================================================
--- trunk/fs/ocfs2/journal.c	2005-05-27 23:36:01 UTC (rev 2334)
+++ trunk/fs/ocfs2/journal.c	2005-05-28 04:24:15 UTC (rev 2335)
@@ -195,10 +195,9 @@
 
 done_free:
 
-	if (handle) {
-		ocfs_commit_unstarted_handle(handle);
-		kfree(handle);
-	}
+	if (handle)
+		ocfs_commit_unstarted_handle(handle); /* will kfree handle */
+
 	mlog_exit(NULL);
 	return NULL;
 }  /*  ocfs_start_trans  */



More information about the Ocfs2-commits mailing list