[Ocfs2-commits] mfasheh commits r2275 - trunk/fs/ocfs2

[svn-commits at oss.oracle.com]

Author: mfasheh
Signed-off-by: manish
Date: 2005-05-18 00:14:24 -0500 (Wed, 18 May 2005)
New Revision: 2275

Modified:
   trunk/fs/ocfs2/dcache.c
   trunk/fs/ocfs2/inode.c
   trunk/fs/ocfs2/namei.c
Log:
* Turn these #warning's into comments... Most of them shouldn't have
  been warnings in the first place.

Signed-off-by: manish



Modified: trunk/fs/ocfs2/dcache.c
===================================================================
--- trunk/fs/ocfs2/dcache.c	2005-05-18 05:04:11 UTC (rev 2274)
+++ trunk/fs/ocfs2/dcache.c	2005-05-18 05:14:24 UTC (rev 2275)
@@ -68,7 +68,7 @@
 	}
 	spin_unlock(&OCFS_I(inode)->ip_lock);
 
-#warning "should we do this for all files?"
+	/* XXX: Should we do this for all files? */
 	if (S_ISDIR(inode->i_mode) && (!inode->i_nlink)) {
 		mlog(0, "dir inode (%"MLFu64") orphaned, returning false\n",
 		     OCFS_I(inode)->ip_blkno);

Modified: trunk/fs/ocfs2/inode.c
===================================================================
--- trunk/fs/ocfs2/inode.c	2005-05-18 05:04:11 UTC (rev 2274)
+++ trunk/fs/ocfs2/inode.c	2005-05-18 05:14:24 UTC (rev 2275)
@@ -806,8 +806,9 @@
 	u64 p_blkno;
 	int readflags = OCFS_BH_CACHED;
 
-#warning only turn this on if we know we can deal with read_block returning nothing
 #if 0
+	/* only turn this on if we know we can deal with read_block
+	 * returning nothing */
 	if (reada)
 		readflags |= OCFS_BH_READAHEAD;
 #endif
@@ -922,8 +923,8 @@
 	fe->i_atime = inode->i_atime.tv_sec;
 	fe->i_ctime = inode->i_ctime.tv_sec;
 	fe->i_mtime = inode->i_mtime.tv_sec;
-#warning "do we want to update these here?"
-//	fe->i_dtime = inode->i_dtime.tv_sec;
+	/* XXX: Do we want to update i_dtime here? */
+	/* fe->i_dtime = inode->i_dtime.tv_sec; */
 
 	status = ocfs_journal_dirty(handle, bh);
 	if (status < 0)

Modified: trunk/fs/ocfs2/namei.c
===================================================================
--- trunk/fs/ocfs2/namei.c	2005-05-18 05:04:11 UTC (rev 2274)
+++ trunk/fs/ocfs2/namei.c	2005-05-18 05:14:24 UTC (rev 2275)
@@ -1913,7 +1913,7 @@
 				}
 				num++;
 		
-#warning questionable readahead stuff here	
+				/* XXX: questionable readahead stuff here */
 				bh = ocfs_bread(dir, b++, &err, 1);
 				bh_use[ra_max] = bh;
 #if 0		// ???