[Ocfs2-commits] rev 746 - trunk/src

[svn-commits at oss.oracle.com]

Author: mfasheh
Date: 2004-03-02 16:00:35 -0600 (Tue, 02 Mar 2004)
New Revision: 746

Modified:
   trunk/src/inode.c
   trunk/src/namei.c
Log:
* fix a minor inode leak in a failure case of mknod.



Modified: trunk/src/inode.c
===================================================================
--- trunk/src/inode.c	2004-03-02 21:38:47 UTC (rev 745)
+++ trunk/src/inode.c	2004-03-02 22:00:35 UTC (rev 746)
@@ -729,6 +729,11 @@
 		goto bail;
 	}
 
+	/* offset == 0 if this inode is newly created and hasn't been
+	 * filled in yet. */
+	if (offset == 0)
+		goto bail;
+
 	if (inode_data_is_oin (inode)) {
 		LOG_TRACE_STR ("inode with oin : clear inode");
 

Modified: trunk/src/namei.c
===================================================================
--- trunk/src/namei.c	2004-03-02 21:38:47 UTC (rev 745)
+++ trunk/src/namei.c	2004-03-02 22:00:35 UTC (rev 746)
@@ -316,6 +316,9 @@
 	if (lock_bh != NULL) 
 		brelse(lock_bh);
 
+	if ((status < 0) && inode)
+		iput(inode);
+
 	if (status < 0)
 		ocfs_bh_sem_hash_cleanup_pid(ocfs_getpid());