[Ocfs2-commits] jlbec commits r1077 - in branches/format-changes: . src

[svn-commits at oss.oracle.com]

Author: jlbec
Date: 2004-06-13 01:54:14 -0500 (Sun, 13 Jun 2004)
New Revision: 1077

Modified:
   branches/format-changes/TODO
   branches/format-changes/src/ocfs.h
   branches/format-changes/src/super.c
Log:

o Remove the fe_cache.  Unused, and a bad idea.



Modified: branches/format-changes/TODO
===================================================================
--- branches/format-changes/TODO	2004-06-13 06:05:42 UTC (rev 1076)
+++ branches/format-changes/TODO	2004-06-13 06:54:14 UTC (rev 1077)
@@ -1,5 +1,6 @@
 * figure out what to do about old style cdsl. Either we error when we see it
   (in the module), or we provide an fsck to find and fix them.
+	- Probably should be handle by the conversion.
 
 * fsck must be able to replay the journal
 
@@ -13,13 +14,6 @@
 * Make bitmap free functions do their job without relocking the bitmaps for
   each record.
 
-* get rid of osb->curr_trans_id as it was never used (always zero)
-
-* get rid of all the:
-	changeSeqNum = osb->curr_trans_id; 
-	DISK_LOCK_SEQNUM(fe) = changeSeqNum;
-  code as it is equally useless.
-
 * get rid of as much of lockres as possible.
 
 * make slabs for: ocfs_journal_handle, and ocfs_journal_copyout and maybe
@@ -54,6 +48,8 @@
 * Local alloc structure needs to be turned into a file entry so creating an
   inode for it is trivial. This way we can use the inodes locking primitives
   instead of special casing stuff and using osb->local_alloc_sem.
+	- It's an inode now, but we need to finish making it use inode
+	  locking primatives.
 
 * We need to be able to delete stuff from the inode alloc system file(s).
 

Modified: branches/format-changes/src/ocfs.h
===================================================================
--- branches/format-changes/src/ocfs.h	2004-06-13 06:05:42 UTC (rev 1076)
+++ branches/format-changes/src/ocfs.h	2004-06-13 06:54:14 UTC (rev 1077)
@@ -997,7 +997,6 @@
 	struct semaphore global_res;
 	struct list_head osb_next;	/* List of all volumes */
 	kmem_cache_t *inode_cache;
-	kmem_cache_t *fe_cache;
 	kmem_cache_t *extent_cache;
 	kmem_cache_t *bh_sem_cache;
 	__u32 flags;

Modified: branches/format-changes/src/super.c
===================================================================
--- branches/format-changes/src/super.c	2004-06-13 06:05:42 UTC (rev 1076)
+++ branches/format-changes/src/super.c	2004-06-13 06:54:14 UTC (rev 1077)
@@ -790,9 +790,6 @@
 		 sizeof(ocfs_inode_private), 0, SLAB_NO_REAP | SLAB_HWCACHE_ALIGN,
 		 NULL, NULL);
 
-	OcfsGlobalCtxt.fe_cache = kmem_cache_create ("ocfs2_fileentry",
-		512, 0, SLAB_NO_REAP | SLAB_HWCACHE_ALIGN, NULL, NULL);
-
 	OcfsGlobalCtxt.extent_cache = kmem_cache_create ("ocfs2_extent",
 		sizeof(ocfs_extent) + OCFS_POINTER_SIZE, 0, SLAB_NO_REAP | SLAB_HWCACHE_ALIGN,
 		NULL, NULL);
@@ -813,7 +810,6 @@
 static void ocfs_free_mem_lists (void)
 {
 	kmem_cache_destroy (OcfsGlobalCtxt.inode_cache);
-	kmem_cache_destroy (OcfsGlobalCtxt.fe_cache);
 	kmem_cache_destroy (OcfsGlobalCtxt.extent_cache);
 	kmem_cache_destroy (OcfsGlobalCtxt.bh_sem_cache);
 	OCFS_CLEAR_FLAG (OcfsGlobalCtxt.flags, OCFS_FLAG_MEM_LISTS_INITIALIZED);