[Ocfs2-commits] bryce commits r1679 - branches/bryce/src

svn-commits at oss.oracle.com svn-commits at oss.oracle.com
Wed Dec 1 06:03:33 CST 2004


Author: bryce
Date: 2004-12-01 06:03:31 -0600 (Wed, 01 Dec 2004)
New Revision: 1679

Modified:
   branches/bryce/src/localalloc.c
Log:
Not sure what to do with this line
        cpu_to_le32(alloc->id1.bitmap1.bryce_i_used) += *num_bits;        
since num_bits is a pointer... gurrrr
thers also one other place that I'm not sure what to do with
alloc->id1.bitmap1.bryce_i_total = cpu_to_le32(le32_to_cpu(cluster_count
));
since the two would cancel each other out it shouldn't have any
BE twiddling being used on it.. I think



Modified: branches/bryce/src/localalloc.c
===================================================================
--- branches/bryce/src/localalloc.c	2004-12-01 02:55:26 UTC (rev 1678)
+++ branches/bryce/src/localalloc.c	2004-12-01 12:03:31 UTC (rev 1679)
@@ -716,9 +716,9 @@
 	int i;
 	LOG_ENTRY();
 
-	cpu_to_le32(alloc->id1.bitmap1.bryce_i_total) = 0;
-	cpu_to_le32(alloc->id1.bitmap1.bryce_i_used) = 0;
-	cpu_to_le32(LOCAL_ALLOC(alloc)->bryce_la_bm_off) = 0;
+	alloc->id1.bitmap1.bryce_i_total = cpu_to_le32(0);
+	alloc->id1.bitmap1.bryce_i_used = cpu_to_le32(0);
+	LOCAL_ALLOC(alloc)->bryce_la_bm_off = cpu_to_le32(0);
 	for(i = 0; i < le16_to_cpu(LOCAL_ALLOC(alloc)->bryce_la_size); i++)
 		LOCAL_ALLOC(alloc)->la_bitmap[i] = 0;
 
@@ -899,13 +899,13 @@
 
 	alloc = (ocfs2_dinode *) osb->local_alloc_bh->b_data;
 
-	cpu_to_le32(LOCAL_ALLOC(alloc)->bryce_la_bm_off) = cluster_off;
-	cpu_to_le32(alloc->id1.bitmap1.bryce_i_total) = le32_to_cpu(cluster_count);
+	LOCAL_ALLOC(alloc)->bryce_la_bm_off = cpu_to_le32(cluster_off);
+	alloc->id1.bitmap1.bryce_i_total = cpu_to_le32(le32_to_cpu(cluster_count));
 	/* just in case... In the future when we find space ourselves,
 	 * we don't have to get all contiguous -- but we'll have to
 	 * set all previously used bits in bitmap and update
 	 * la_bits_set before setting the bits in the main bitmap. */
-	cpu_to_le32(alloc->id1.bitmap1.bryce_i_used) = 0;
+	alloc->id1.bitmap1.bryce_i_used = cpu_to_le32(0);
 	memset(LOCAL_ALLOC(alloc)->la_bitmap, 0,
 	       le16_to_cpu(LOCAL_ALLOC(alloc)->bryce_la_size));
 



More information about the Ocfs2-commits mailing list