<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
I believe this fixes a problem that is reported by the GCC 4.8.5 compiler (default on OL7 it seems). So -*really* pretty old. I wouldn't worry about these compiler warnings, personally. I'd rather not overly avoid them at the cost of code that could possibly
be too implementation-dependent.</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Nick Alcock via DTrace-devel <dtrace-devel@oss.oracle.com><br>
<b>Sent:</b> Friday, December 1, 2023 10:06 AM<br>
<b>To:</b> eugene.loh--- via DTrace-devel <dtrace-devel@oss.oracle.com><br>
<b>Subject:</b> Re: [DTrace-devel] [PATCH 1/3] Fix "missing braces" message with older compilers</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On 30 Nov 2023, eugene loh uttered the following:<br>
<br>
> From: Eugene Loh <eugene.loh@oracle.com><br>
><br>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com><br>
> ---<br>
> dtprobed/dtprobed.c | 2 +-<br>
> libdtrace/dt_proc.c | 8 ++++----<br>
> libdtrace/dt_symtab.c | 2 +-<br>
> libport/daemonize.c | 2 +-<br>
> 4 files changed, 7 insertions(+), 7 deletions(-)<br>
><br>
> diff --git a/dtprobed/dtprobed.c b/dtprobed/dtprobed.c<br>
> index 507a412a..c2e93d48 100644<br>
> --- a/dtprobed/dtprobed.c<br>
> +++ b/dtprobed/dtprobed.c<br>
> @@ -848,7 +848,7 @@ main(int argc, char *argv[])<br>
> char *devname = "dtrace/helper";<br>
> int sync_fd = -1;<br>
> int ret;<br>
> - struct sigaction sa = {0};<br>
> + struct sigaction sa = {{0}};<br>
<br>
This depends on an implementation detail of glibc (that struct sigaction<br>
happens to have a union in it as the first member) just to get rid of a<br>
pedantic warning. This feels... excessive to me?<br>
<br>
How old are 'older compilers' anyway?<br>
<br>
-- <br>
NULL && (void)<br>
<br>
_______________________________________________<br>
DTrace-devel mailing list<br>
DTrace-devel@oss.oracle.com<br>
<a href="https://oss.oracle.com/mailman/listinfo/dtrace-devel">https://oss.oracle.com/mailman/listinfo/dtrace-devel</a><br>
</div>
</span></font></div>
</body>
</html>