<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Reviewed-by: Eugene Loh <eugene.loh@oracle.com>
<div><br>
</div>
<div>Incidentally, it might be better to indent starting MIN() on its own line. I know this predates this patch, but now might be a reasonable time to change it.</div>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Kris Van Hees via DTrace-devel <dtrace-devel@oss.oracle.com><br>
<b>Sent:</b> Friday, August 19, 2022 10:26 AM<br>
<b>To:</b> dtrace-devel@oss.oracle.com <dtrace-devel@oss.oracle.com><br>
<b>Subject:</b> [DTrace-devel] [PATCH 3/5] Allow NULL as map name in dt_bpf_map_create()</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com><br>
---<br>
libdtrace/dt_bpf.c | 5 +++--<br>
1 file changed, 3 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/libdtrace/dt_bpf.c b/libdtrace/dt_bpf.c<br>
index e92d34ee..7a886278 100644<br>
--- a/libdtrace/dt_bpf.c<br>
+++ b/libdtrace/dt_bpf.c<br>
@@ -113,8 +113,9 @@ dt_bpf_map_create(enum bpf_map_type map_type, const char *name,<br>
attr.value_size = value_size;<br>
attr.max_entries = max_entries;<br>
attr.map_flags = map_flags;<br>
- memcpy(attr.map_name, name, MIN(strlen(name),<br>
- sizeof(attr.map_name) - 1));<br>
+ if (name)<br>
+ memcpy(attr.map_name, name, MIN(strlen(name),<br>
+ sizeof(attr.map_name) - 1));<br>
<br>
return bpf(BPF_MAP_CREATE, &attr);<br>
}<br>
-- <br>
2.34.1<br>
<br>
<br>
_______________________________________________<br>
DTrace-devel mailing list<br>
DTrace-devel@oss.oracle.com<br>
<a href="https://oss.oracle.com/mailman/listinfo/dtrace-devel">https://oss.oracle.com/mailman/listinfo/dtrace-devel</a><br>
</div>
</span></font></div>
</body>
</html>