[DTrace-devel] [PATCH] test: fix leak of $testerr.tmp

Eugene Loh eugene.loh at oracle.com
Mon Mar 11 17:24:54 UTC 2024


Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
remove the "Not for this release" comment

FWIW, this patch introduces a tab, which seems to be an oddity in this 
portion of the script.

On 3/11/24 08:03, Nick Alcock via DTrace-devel wrote:
> Nothing ever deletes it, so thousands of them build up in the
> $tmpdir.  Trivial fix.
>
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> ---
>   runtest.sh | 1 +
>   1 file changed, 1 insertion(+)
>
> Not for this release, obviously!
>
> diff --git a/runtest.sh b/runtest.sh
> index 35d5006978469..a9320699bfbab 100755
> --- a/runtest.sh
> +++ b/runtest.sh
> @@ -1316,6 +1316,7 @@ for dt in $dtrace; do
>   
>               # Account for an error message change in CTF
>               sed -e 's/Invalid member name/Member name not found/' $testerr.tmp > $testerr
> +	    rm -f $testerr.tmp
>   
>               # Note if dtrace mentions running out of memory at any point.
>               # If it does, this test quietly becomes an expected failure



More information about the DTrace-devel mailing list