[DTrace-devel] [oracle/dtrace-utils] feb883: test: remove @@xfail for tst.nested-unnamed-structs.d

[Nick Alcock]

  Branch: refs/heads/devel
  Home:   https://github.com/oracle/dtrace-utils
  Commit: feb883fc670e2a9123732a50d4c9e919c68398d2
      https://github.com/oracle/dtrace-utils/commit/feb883fc670e2a9123732a50d4c9e919c68398d2
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
    M test/unittest/types/tst.nested-unnamed-structs.d

  Log Message:
  -----------
  test: remove @@xfail for tst.nested-unnamed-structs.d

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Nick Alcock <nick.alcock at oracle.com>
Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


  Commit: f7f7b65172c07df8c90b68b5dea5b8aa10ff937c
      https://github.com/oracle/dtrace-utils/commit/f7f7b65172c07df8c90b68b5dea5b8aa10ff937c
  Author: Nick Alcock <nick.alcock at oracle.com>
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
    M test/unittest/bitfields/tst.bitfield-offset.x

  Log Message:
  -----------
  test: fix the bitfield-offset fix

Many systems on which CTF is too old for tst.bitfield-offset.d to pass will
also be too old for objdump --ctf=.ctf to work: in that case, we have no way
to tell how new the CTF is (and thus whether this bug is expected to be
fixed), so we have to skip it.

Even figuring out if this is the case is hard.  We don't want to try to
objdump the entire kernel CTFA again in case it works (it's huge and takes
ages to dump: we're not exiting early on a version check here, after all).
But objdump returns with an exitcode of 1 both if an unrecognized option is
found *and* if the target contains no CTF at all -- so we must literally
grep for 'Unrecognized option' (under LANG=C) to be sure of spotting an
instance we must skip.  (We also check for a zero exit code, because if our
random test executable *does* contain CTF and dumping it works there's no
need to grep the stderr for anything at all.)

Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


Compare: https://github.com/oracle/dtrace-utils/compare/55e7f1b94aa0...f7f7b65172c0

To unsubscribe from these emails, change your notification settings at https://github.com/oracle/dtrace-utils/settings/notifications