[DTrace-devel] [PATCH] test: Bump timeouts up for tests with large BPF programs

[Eugene Loh]

On 3/4/24 12:59, Kris Van Hees wrote:

> On Fri, Mar 01, 2024 at 09:10:45PM -0500, eugene.loh--- via DTrace-devel wrote:
>> From: Eugene Loh <eugene.loh at oracle.com>
>>
>> With some kernels, the BPF verifier is taking a long time to load
>> large BPF programs.  This causes some tests to time out on some
>> kernels.  Bump a few timeouts up accordingly, so that these DTrace
>> tests can pass independently of tuning efforts in the kernel.
>>
>> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
> Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>
>
> ... and hopefully we can bring this down again once we have figured out where
> in the kernel code this slowdown is happening and get that fixed.

This seems to be resolved in upstream kernels.  Anyhow, I filed Oracle 
bug 36366133 and assigned to Alan, per conversations with him.

>> ---
>>   test/unittest/arithmetic/tst.cast-exp-assoc.d   | 3 ++-
>>   test/unittest/options/tst.bpflogsize-cmdline.sh | 3 ++-
>>   test/unittest/options/tst.bpflogsize-pragma.sh  | 3 ++-
>>   3 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/test/unittest/arithmetic/tst.cast-exp-assoc.d b/test/unittest/arithmetic/tst.cast-exp-assoc.d
>> index 867833f5..93843c84 100644
>> --- a/test/unittest/arithmetic/tst.cast-exp-assoc.d
>> +++ b/test/unittest/arithmetic/tst.cast-exp-assoc.d
>> @@ -1,6 +1,6 @@
>>   /*
>>    * Oracle Linux DTrace.
>> - * Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights reserved.
>> + * Copyright (c) 2022, 2024, Oracle and/or its affiliates. All rights reserved.
>>    * Licensed under the Universal Permissive License v 1.0 as shown at
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>> @@ -12,6 +12,7 @@
>>    * SECTION: Types, Operators, and Expressions/Arithmetic Operators
>>    */
>>   /* @@runtest-opts: -qC */
>> +/* @@timeout: 120 */
>>   
>>   signed char c[int], c0[int];
>>   short s[int], s0[int];
>> diff --git a/test/unittest/options/tst.bpflogsize-cmdline.sh b/test/unittest/options/tst.bpflogsize-cmdline.sh
>> index 2d85e12c..509f9d07 100755
>> --- a/test/unittest/options/tst.bpflogsize-cmdline.sh
>> +++ b/test/unittest/options/tst.bpflogsize-cmdline.sh
>> @@ -1,10 +1,11 @@
>>   #!/bin/bash
>>   #
>>   # Oracle Linux DTrace.
>> -# Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
>> +# Copyright (c) 2021, 2024, Oracle and/or its affiliates. All rights reserved.
>>   # Licensed under the Universal Permissive License v 1.0 as shown at
>>   # http://oss.oracle.com/licenses/upl.
>>   #
>> +# @@timeout: 100
>>   
>>   dtrace=$1
>>   
>> diff --git a/test/unittest/options/tst.bpflogsize-pragma.sh b/test/unittest/options/tst.bpflogsize-pragma.sh
>> index 5d03b5f7..3dea3dd4 100755
>> --- a/test/unittest/options/tst.bpflogsize-pragma.sh
>> +++ b/test/unittest/options/tst.bpflogsize-pragma.sh
>> @@ -1,10 +1,11 @@
>>   #!/bin/bash
>>   #
>>   # Oracle Linux DTrace.
>> -# Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
>> +# Copyright (c) 2021, 2024, Oracle and/or its affiliates. All rights reserved.
>>   # Licensed under the Universal Permissive License v 1.0 as shown at
>>   # http://oss.oracle.com/licenses/upl.
>>   #
>> +# @@timeout: 100
>>   
>>   dtrace=$1
>>   
>> -- 
>> 2.18.4
>>
>>
>> _______________________________________________
>> DTrace-devel mailing list
>> DTrace-devel at oss.oracle.com
>> https://oss.oracle.com/mailman/listinfo/dtrace-devel