[DTrace-devel] [PATCH] bpf: use correct loop bound for conf->cpus traversal in cpuinfo map creation

Nick Alcock nick.alcock at oracle.com
Mon Mar 4 18:23:26 UTC 2024


On 1 Mar 2024, Kris Van Hees told this:

> On Fri, Mar 01, 2024 at 08:45:35PM +0000, Nick Alcock via DTrace-devel wrote:
>> We were using the wrong bound, causing a buffer overrun on machines with
>> fewer online CPUs than possible CPUs.
>
> ... on machines with online CPUs that do not have sequential CPU ids.
>
> (You could even add an exaxmple, like: 1, 2, 3, 6.)
>
>> (Add an assertion to verify that there are never more online CPUs
>> than possible CPUs.)
>> 
>> Orabug: 36356681
>> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
>
> Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>
>
> ... with the commit msg change listed above

Agreed. Pushed again.



More information about the DTrace-devel mailing list