[DTrace-devel] [PATCH 1/2] test: Add xfail pending binutils fix

Kris Van Hees kvanhees at kvh-deb-bpf.us.oracle.com
Tue Jan 30 16:17:44 UTC 2024


On Fri, Jan 12, 2024 at 01:30:59PM -0500, eugene.loh at oracle.com wrote:
> 
> This test started to fail with commit 2096fd77
> "usdt: remove relocations rather than changing their type to R_*_NONE"
> 
> Add an xfail pending a binutils fix to not consider R_*_NONE invalid.
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

... though I hope we can revert this and the quoted one very soon.

> ---
>  test/unittest/usdt/tst.static2.sh | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/test/unittest/usdt/tst.static2.sh b/test/unittest/usdt/tst.static2.sh
> index ec611873..8a2417cd 100755
> --- a/test/unittest/usdt/tst.static2.sh
> +++ b/test/unittest/usdt/tst.static2.sh
> @@ -9,6 +9,8 @@
>  # files containing the probes have already been modified. This tests that
>  # case by generating the DOF object, removing it, and building it again.
>  
> +# @@xfail: pending binutils fix to not consider R_*_NONE invalid
> +
>  if [ $# != 1 ]; then
>  	echo expected one argument: '<'dtrace-path'>'
>  	exit 2
> -- 
> 2.18.4
> 
> 



More information about the DTrace-devel mailing list