[DTrace-devel] [PATCH v2 2/5] Add -xcpu support to dtrace provider

Eugene Loh eugene.loh at oracle.com
Wed Jan 17 17:54:11 UTC 2024


On 1/17/24 11:42, Kris Van Hees wrote:

> I think this will cause Valgrind not to work right with -xcpu.  See below...
>
> On Thu, Jan 11, 2024 at 12:13:30AM -0500, eugene.loh--- via DTrace-devel wrote:
>> diff --git a/libdtrace/dt_work.c b/libdtrace/dt_work.c
>> @@ -131,6 +131,76 @@ dtrace_status(dtrace_hdl_t *dtp)
>>
>> +	BEGIN_probe();
> I believe this should be:
> 	VALGRIND_NON_SIMD_CALL0(BEGIN_probe);
>
>> +	END_probe();
> I believe this should be:
> 	VALGRIND_NON_SIMD_CALL0(END_probe);

Oops, right.  My laziness.  And need "if (RUNNING_ON_VALGRIND) ... 
else...".  v3 coming right up.



More information about the DTrace-devel mailing list